feat: add batch_transaction_get_merkle
#170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
force-pushed
the
feat/add-batch-transaction-get-merkle
branch
from
e730dac to
5b6876b
Compare
oleonardolima
force-pushed
the
feat/add-batch-transaction-get-merkle
branch
3 times, most recently
from
46a8817 to
2dfc299
Compare
3 tasks
ValuedMammal
reviewed
Jul 7, 2025
- adds the new batch method for `blockchain.transaction.get_merkle`. - adds a new test for `batch_transaction_get_merkle` with 3 different txids and block_heights.
oleonardolima
force-pushed
the
feat/add-batch-transaction-get-merkle
branch
from
2dfc299 to
74ac97c
Compare
|
ACK 74ac97c I tested by patching |
|
Based on above ACKs this should be ready to merge. |
oleonardolima
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Aug 4, 2025
…le` API b663940 chore(bdk-electrum): use new `batch_transaction_get_merkle` API (Leonardo Lima) Pull request description: fixes #1987 depends on bitcoindevkit/rust-electrum-client#170 ### Description - update `batch_fetch_anchors` to use `batch_transaction_get_merkle` method instead of manually creating the batch call. ### Changelog notice ```md ### Changes - Use new `batch_transaction_get_merkle` method instead of batch raw calls ``` ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing ACKs for top commit: ValuedMammal: ACK b663940 LagginTimes: ACK b663940 Tree-SHA512: 8c08bcaf99bb65098015995eae67c710fbe2f8e76d47796aebbfba1c5a1c78174023be3cb21299e4c820d156110742c9e85819c253dcf9bc3e1fa1621ca35378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses bitcoindevkit/bdk#1987
blockchain.transaction.get_merkle.batch_transaction_get_merklewith 3 differenttxids and block_heights.