-
-
Notifications
You must be signed in to change notification settings - Fork 16
Globally disable follow redirects #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arnau Mora <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the sense in leaving followRedirects = false
?
Ooops absolutely my fault |
Signed-off-by: Arnau Mora <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests need to be adapted
Signed-off-by: Arnau Mora <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR relocates the redirect disabling configuration from engine-specific settings to a global HTTP client configuration to ensure consistent behavior across all engines.
- Moves redirect disabling from conditional engine-specific blocks to global client configuration
- Adds explanatory comment about redirect handling being managed by CalendarFetcher
- Simplifies the configuration logic by removing conditional redirect settings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Purpose
We are trying to disable redirection following in the engine config. We don't even want to disable redirection, so remove that line.We do have to disable redirection, it's handled by
CalendarFetcher
. Following the docs, this is the way to disable it so it can be handled by it.Short description
Remove the redirection disable in engine config.Checklist