Skip to content

Conversation

sig-abyreddy
Copy link
Contributor

Description

Fixed sonarqube findings around go mod file detector

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses SonarQube code quality findings in the Go module file detector components. The changes focus on improving code quality by implementing missing hashCode method and fixing regex patterns and boolean comparisons.

  • Added missing hashCode implementation to maintain equals/hashCode contract
  • Simplified regex pattern for dependency parsing
  • Changed boolean comparison style for SonarQube compliance

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
GoDependencyNode.java Added missing hashCode method and Objects import
GoModFileParser.java Simplified regex pattern for dependency parsing
GoModDependencyResolver.java Changed boolean comparison from negation to explicit false comparison

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

…detectables/go/gomodfile/parse/GoModDependencyResolver.java

Co-authored-by: Copilot <[email protected]>
@sig-abyreddy sig-abyreddy requested a review from Copilot October 9, 2025 08:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@blackducksoftware blackducksoftware deleted a comment from Copilot AI Oct 9, 2025
@sig-abyreddy sig-abyreddy merged commit 02611ef into master Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants