Skip to content

Fix sonarqube findings under go mod file detector #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

Fix sonarqube findings under go mod file detector #1571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d6d1b2
Fix sonarqube findings under go mod file detector
sig-abyreddy Oct 9, 2025
ecf8807
Update detectable/src/main/java/com/blackduck/integration/detectable/…
sig-abyreddy Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../com/blackduck/integration/detectable/detectables/go/gomodfile/parse/GoModFileParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class GoModFileParser {
private static final Pattern MODULE_PATTERN = Pattern.compile("^module\\s+(.+)$");
private static final Pattern GO_VERSION_PATTERN = Pattern.compile("^go\\s+(.+)$");
private static final Pattern TOOLCHAIN_PATTERN = Pattern.compile("^toolchain\\s+(.+)$");
private static final Pattern DEPENDENCY_PATTERN = Pattern.compile("^\\s*([^\\s]+)\\s+([^\\s]+(?:-[^\\s]+)*)(?:\\s+//\\s*(.+))?$");
private static final Pattern DEPENDENCY_PATTERN = Pattern.compile("^\\s*([^\\s]+)\\s+([^\\s]+)(?:\\s+//\\s*(.+))?$");
private static final Pattern REPLACE_PATTERN = Pattern.compile("^\\s*([^\\s]+)(?:\\s+([^\\s]+))?\\s+=>");
private static final Pattern COMMENT_PATTERN = Pattern.compile("^\\s*//.*$");
private static final Pattern EMPTY_LINE_PATTERN = Pattern.compile("^\\s*$");
Expand Down
6 changes: 6 additions & 0 deletions ...ackduck/integration/detectable/detectables/go/gomodfile/parse/model/GoDependencyNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.blackduck.integration.detectable.detectables.go.gomodfile.parse.model;

import java.util.List;
import java.util.Objects;

import com.blackduck.integration.bdio.model.dependency.Dependency;

Expand Down Expand Up @@ -45,6 +46,11 @@ public boolean equals(Object o) {

return dependency != null ? dependency.equals(that.dependency) : that.dependency == null;
}

@Override
public int hashCode() {
return Objects.hash(dependency, children, isRootNode);
}

/**
* Utility method to get the total count of all dependencies in the graph (including transitive).
Expand Down