/lib/{LIBRARY} redirect to detail page (#1939) #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveoconnor
force-pushed
the
doc/1939-lib-slug-redirect
branch
from
45b9418 to
c5da53a
Compare
|
tested in localhost. URL tested is Looks good, ready to merge @daveoconnor |
daveoconnor
force-pushed
the
doc/1939-lib-slug-redirect
branch
from
c5da53a to
f0bbd8b
Compare
|
Thanks @karimarie67 Holding off on merging this for now until Rob gives the go ahead, he asked us to wait on this one. |
daveoconnor
force-pushed
the
doc/1939-lib-slug-redirect
branch
from
f0bbd8b to
ad845ac
Compare
daveoconnor
force-pushed
the
doc/1939-lib-slug-redirect
branch
from
ad845ac to
0d4dcf3
Compare
daveoconnor
force-pushed
the
doc/1939-lib-slug-redirect
branch
from
0d4dcf3 to
d7c4851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to issue #1939.
Adds support for /lib/{LIBRARY} redirects to the matching library detail page.
Testing:
/lib/unordered/ should redirect to the detail page for the library set in the slug. The version it gets redirected to is based on the last visited, or
latestif not previously visited.Note that locally
/lib/unordered(missing trailing slash) won't work but should work on deployed environments.