Skip to content

Conversation

@iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Dec 23, 2025

Messages are actually deleted from the server. I've checked this in Desktop.

See ChatId::delete_ex():

"UPDATE imap SET target=? WHERE rfc724_mid IN (SELECT rfc724_mid FROM msgs WHERE chat_id=?)",
(delete_msgs_target, self,),

Messages are actually deleted from the server. I've checked this in Desktop.
@iequidoo iequidoo requested review from link2xt and r10s December 23, 2025 09:34
Copy link
Contributor

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for taking care!

however, we should start speaking also in core more about "relay" and not "server" - it makes a difference over time. so i'd change "server" to "relay" here for new things we document

@iequidoo iequidoo merged commit 294e23d into main Dec 24, 2025
30 checks passed
@iequidoo iequidoo deleted the iequidoo/delete-chat-doc branch December 24, 2025 03:56
@iequidoo
Copy link
Collaborator Author

Decided not to change "server" to "relay" yet. Maybe better to make such a replacement in all places in a separate PR to avoid having mixed wording

@link2xt
Copy link
Collaborator

link2xt commented Dec 24, 2025

We also have some inconsistency like "account" <-> "profile" between core and UIs. If it is still called "transport" in SQL and APIs such as events then maybe better keep it this way in the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants