Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

@hanna-skryl hanna-skryl commented Dec 10, 2025

Closes #1139

Add axeCategories helper for streamlined category configuration.

  • Auto-generates accessibility category when no categories are provided
  • Expands user-provided categories for multi-URL configurations

Note

The initially proposed mergeAxeGroupRefs was replaced with axeCategories (see the updated issue description) for a more intuitive API that describes what you get rather than how it works internally.

The Lighthouse plugin will be updated to follow this pattern (lighthouseCategories).

Note

The auto-generated category uses the slug axe-a11y to coexist with Lighthouse's a11y category. A composeCategory helper for combining plugins is planned (#1179).

@hanna-skryl hanna-skryl self-assigned this Dec 10, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 axe-plugin labels Dec 10, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2025

View your CI Pipeline Execution ↗ for commit 1487708

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 23s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 16s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 51s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-11 15:36:04 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1182

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1182

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1182

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1182

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1182

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1182

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1182

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1182

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1182

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1182

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1182

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1182

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1182

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1182

commit: 1487708

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit f2e558b with previous commit a86654b.

💼 Project plugin-axe

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 69 🟡 68 ↓ −1
Code coverage 🟢 92 🟢 93 ↑ +0.9

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDoc coverage Documentation coverage 🟡 69 🟡 68 ↓ −1
Code coverage Code coverage metrics 🟢 92 🟢 93 ↑ +0.9

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDoc coverage Functions coverage 🟥 13 undocumented functions 🟥 21 undocumented functions ↑ +61.5 %
Code coverage Line coverage 🟨 67.2 % 🟨 72.3 % ↑ +7.5 %
Code coverage Branch coverage 🟨 85.1 % 🟨 86.4 % ↑ +1.5 %

439 other audits are unchanged.

💼 Project cli

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 93 🟢 92 ↓ −0.1

5 other categories are unchanged.

👎 1 group regressed, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 93 🟢 92 ↓ −0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 89.1 % 🟨 88.5 % ↓ −0.6 %
Code coverage Branch coverage 🟨 84.4 % 🟨 84.2 % ↓ −0.3 %

441 other audits are unchanged.


12 other projects are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit f2e558b with previous commit a86654b.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 43 🔴 38 ↓ −5.2
Best Practices 🟢 100 🟢 97 ↓ −3.4
Code style 🟢 100 🟢 99 ↓ −0.4
Code coverage 🟡 89 🟡 89 ↑ +0.1
Documentation 🔴 35 🔴 35 ↓ −0.1
Axe Accessibility n/a (*) 🟡 87 n/a (*)
Bug prevention 🟡 67 🟡 67
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
SEO 🟢 92 🟢 92

(*) New category.

👍 1 group improved, 👎 6 groups regressed, 👍 3 audits improved, 👎 10 audits regressed, 19 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
ESLint Style guide (import) 🟢 100 🟡 80 ↓ −20
Axe Accessibility ARIA 🟢 95 🟡 89 ↓ −5.3
Lighthouse Performance 🔴 43 🔴 38 ↓ −5.2
Lighthouse Best Practices 🟢 100 🟢 97 ↓ −3.4
ESLint Suggestions 🟢 100 🟢 99 ↓ −0.4
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 35 🔴 35 ↓ −0.1

27 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 430 ms 🟥 Root document took 2,700 ms ↑ +522.8 %
Axe Accessibility Elements must only use permitted ARIA attributes 🟩 96 elements 🟥 1 error ↓ −99 %
ESLint Forbid unassigned imports 🟩 passed 🟥 1 warning ↑ +∞ %
Lighthouse No browser errors logged to the console 🟩 passed 🟥 failed ↓ −100 %
Lighthouse Enable text compression 🟩 0 🟨 Potential savings of 29 KiB  −∞ %
Lighthouse Speed Index 🟨 5.6 s 🟥 10.1 s ↑ +80.8 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟥 5.3 s ↑ +77.5 %
Lighthouse Total Blocking Time 🟥 1,040 ms 🟥 760 ms ↓ −26.4 %
Lighthouse Time to Interactive 🟥 12.0 s 🟥 15.0 s ↑ +25.2 %
Lighthouse Max Potential First Input Delay 🟥 810 ms 🟥 890 ms ↑ +9.8 %
Code coverage Function coverage 🟩 90.5 % 🟩 90.6 % ↑ +0.1 %
Code coverage Line coverage 🟨 84.8 % 🟨 84.8 % ↑ +0.1 %
JSDoc coverage Functions coverage 🟥 559 undocumented functions 🟥 567 undocumented functions ↑ +1.4 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,055 KiB 🟩 Total size was 2,153 KiB ↑ +4.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +25.2 %
Lighthouse Minimizes main-thread work 🟥 7.4 s 🟥 9.5 s ↑ +28.9 %
Lighthouse Server Backend Latencies 🟩 1,120 ms 🟩 2,310 ms ↑ +105.6 %
Lighthouse Largest Contentful Paint 🟥 10.9 s 🟥 11.7 s ↑ +8.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↑ +33.3 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 164 KiB 🟥 Potential savings of 187 KiB ↑ +20 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 101 KiB 🟥 Potential savings of 103 KiB ↑ +50 %
Lighthouse Avoids an excessive DOM size 🟥 2,353 elements 🟥 2,238 elements ↓ −4.9 %
Lighthouse JavaScript execution time 🟥 2.9 s 🟥 2.8 s ↓ −3.8 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 70 ms ↑ +311.5 %
Axe Accessibility Interactive controls must not be nested 🟩 59 elements 🟩 46 elements ↓ −22 %
Axe Accessibility Elements must only use supported ARIA attributes 🟩 96 elements 🟩 86 elements ↓ −10.4 %
Axe Accessibility ARIA attributes must be used as specified for the element's role 🟩 96 elements 🟩 86 elements ↓ −10.4 %
Axe Accessibility ARIA attributes must conform to valid names 🟩 96 elements 🟩 86 elements ↓ −10.4 %
Axe Accessibility <li> elements must be contained in a <ul> or <ol> 🟩 65 elements 🟩 66 elements ↑ +1.5 %
Code coverage Branch coverage 🟨 87.1 % 🟨 87.1 % ↓ −0.1 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↑ +∞ %

646 other audits are unchanged.

@hanna-skryl hanna-skryl force-pushed the axe-category-aggregation branch from 6040d62 to bbc333d Compare December 10, 2025 21:00
@hanna-skryl hanna-skryl marked this pull request as ready for review December 10, 2025 21:17
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤩
The naming is also better. Thx for the rename!

@hanna-skryl hanna-skryl merged commit 84bb067 into main Dec 11, 2025
24 checks passed
@hanna-skryl hanna-skryl deleted the axe-category-aggregation branch December 11, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 axe-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Axe Plugin - Category Aggregation

4 participants