-
Notifications
You must be signed in to change notification settings - Fork 15
feat(plugin-axe): aggregate categories #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 1487708
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit f2e558b with previous commit a86654b. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 69 | 🟡 68 | |
| Code coverage | 🟢 92 | 🟢 93 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDoc coverage | Documentation coverage | 🟡 69 | 🟡 68 | |
| Code coverage | Code coverage metrics | 🟢 92 | 🟢 93 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDoc coverage | Functions coverage | 🟥 13 undocumented functions | 🟥 21 undocumented functions | |
| Code coverage | Line coverage | 🟨 67.2 % | 🟨 72.3 % | |
| Code coverage | Branch coverage | 🟨 85.1 % | 🟨 86.4 % |
439 other audits are unchanged.
💼 Project cli
😟 Code PushUp report has regressed.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 93 | 🟢 92 |
5 other categories are unchanged.
👎 1 group regressed, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 93 | 🟢 92 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 89.1 % | 🟨 88.5 % | |
| Code coverage | Branch coverage | 🟨 84.4 % | 🟨 84.2 % |
441 other audits are unchanged.
12 other projects are unchanged.
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit f2e558b with previous commit a86654b. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories(*) New category. 👍 1 group improved, 👎 6 groups regressed, 👍 3 audits improved, 👎 10 audits regressed, 19 audits changed without impacting score🗃️ Groups
27 other groups are unchanged. 🛡️ Audits
646 other audits are unchanged. |
6040d62 to
bbc333d
Compare
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤩
The naming is also better. Thx for the rename!
Closes #1139
Add
axeCategorieshelper for streamlined category configuration.Note
The initially proposed
mergeAxeGroupRefswas replaced withaxeCategories(see the updated issue description) for a more intuitive API that describes what you get rather than how it works internally.The Lighthouse plugin will be updated to follow this pattern (
lighthouseCategories).Note
The auto-generated category uses the slug
axe-a11yto coexist with Lighthouse'sa11ycategory. AcomposeCategoryhelper for combining plugins is planned (#1179).