Skip to content

⚡️ Speed up method InfraResource.should_create by 29% #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method InfraResource.should_create by 29% #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions libs/agno/agno/infra/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,20 +149,23 @@ def matches_filters(
type_filter: Optional[str] = None,
) -> bool:
if group_filter is not None:
group_name = self.get_group_name()
logger.debug(f"{self.get_resource_name()}: Checking {group_filter} in {group_name}")
group_name = self.group or self.name
if group_name is None or group_filter not in group_name:
return False

resource_name = self.name
if resource_name is None:
resource_name = self.__class__.__name__

if name_filter is not None:
resource_name = self.get_resource_name()
logger.debug(f"{self.get_resource_name()}: Checking {name_filter} in {resource_name}")
if resource_name is None or name_filter not in resource_name:
return False

if type_filter is not None:
resource_type_list = self.get_resource_type_list()
logger.debug(f"{self.get_resource_name()}: Checking {type_filter.lower()} in {resource_type_list}")
resource_type_list = self.get_resource_type_list_cached()
if resource_type_list is None or type_filter.lower() not in resource_type_list:
return False

return True

def should_create(
Expand Down Expand Up @@ -203,3 +206,13 @@ def __eq__(self, other):
if other.get_resource_type() == self.get_resource_type():
return self.get_resource_name() == other.get_resource_name()
return False

def get_resource_type_list_cached(self) -> list:
if not hasattr(self, "_resource_type_list_cached"):
if self.resource_type_list is None:
self._resource_type_list_cached = [self.get_resource_type().lower()]
else:
self._resource_type_list_cached = [resource_type.lower() for resource_type in self.resource_type_list]
if self.get_resource_type().lower() not in self._resource_type_list_cached:
self._resource_type_list_cached.append(self.get_resource_type().lower())
return self._resource_type_list_cached