Skip to content

System Message Tools #6395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

System Message Tools #6395

wants to merge 20 commits into from

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jul 2, 2025

A remake of #5809

  • Adds support for tools in the form of XML system message instructions and response content parsing + tests
  • Tools are parsed as they come in, converted to ToolCalls, and on the way out converted back to text. Switching between native and non-native tools is interchangeable with this approach.
  • For now, this applies only to models that are NOT known to support native tools
  • Adds a warning to the Agent mode dropdown that shows for any models not known to be great with tools (including models that support native tools)

All models can now be used in Agent mode

@RomneyDa RomneyDa requested a review from a team as a code owner July 2, 2025 07:07
@RomneyDa RomneyDa requested review from sestinj and removed request for a team July 2, 2025 07:07
Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 76f075e
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/686876b289104a0008a90a80

@RomneyDa RomneyDa marked this pull request as draft July 2, 2025 07:07
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 2, 2025
@RomneyDa RomneyDa mentioned this pull request Jul 2, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 6 files and found no issues. Review PR in cubic.dev.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 2 issues across 7 files. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@RomneyDa RomneyDa marked this pull request as ready for review July 2, 2025 10:31
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jul 2, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 5 issues across 38 files. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@RomneyDa
Copy link
Collaborator Author

RomneyDa commented Jul 2, 2025

note to update tool descriptions based on https://github.com/continuedev/continue/pull/6421/files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 5, 2025
@sestinj
Copy link
Contributor

sestinj commented Jul 5, 2025

image

@RomneyDa Tried first with Sonnet and I'm not sure whether this is a parsing bug, but it seems to mostly not stop when a tool is called, so it ends up just streaming multiple tools in a single assistant output, none of them getting called

@sestinj
Copy link
Contributor

sestinj commented Jul 5, 2025

When using o3-mini on the other hand seems like it does actually stop the stream, call the tool, and then call the assistant again.

I'm also seeing a little bit of bugginess around it randomly starting and stopping the stream, but don't have a super clear grasp yet on what causes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants