feat: multi edit and single search and replace tools #7267

RomneyDa · 2025-08-20T23:39:06Z

Description

Adds new multi edit and single edit and replace tools with more robust prompting and args approach inspired from Continue CLI's approach. Adds a simple search/replace tool, the current search and replace tool is hidden, claude and gpt-5 models get a multi-edit tool with array args, and edit_existing_file tool is reinstated for poorer models.
Hides existing search and replace tool for now
Consolidates and simplifies config-dependent tool loading
Also hides the empty expanded codeblock if no changes yet for edit tool UIs

This also adds a diff UI for search and replace tools, merged on separate PR
https://github.com/continuedev/continue/pull/7367/files

CON-3200
CON-2741
CON-3072
CON-3580

Summary by cubic

Adds two precise editing tools: Single Find and Replace and Multi Edit, with client-side implementations and thorough tests. Centralizes tool selection in core to pick the best editing tool per model and environment.

New Features
- Single Find and Replace: exact, validated replacements with optional replace_all.
- Multi Edit: batch multiple edits to one file atomically; sequential, with replace_all support; can create new files by starting with an empty old_string.
- Tool gating: use Multi Edit for Claude and GPT‑5 models; otherwise use Single Find and Replace plus Edit Existing File.
Refactors
- Centralized tool selection in core/tools/index.ts; removed GUI-side model filtering.
- Config loaders now use getBaseToolDefinitions; config-dependent tools receive isRemote and modelName.
- grepSearch enabled only on local workspaces.
- Built-in tool names and client routing updated to include the new tools.
- Added comprehensive tests for both client implementations and updated gating tests.

github-actions

This PR introduces two new editing tools (singleFindAndReplace and multiEdit) to replace the existing edit tools, with dynamic selection based on model capabilities. While the implementation is generally solid with good test coverage, there are concerns about hardcoded model name checks, potential breaking changes for existing tools, and some edge cases that need attention.

💡 To request a new detailed review, comment @continue-detailed-review

core/tools/index.ts

core/tools/definitions/multiEdit.ts

core/tools/definitions/singleFindAndReplace.ts

gui/src/util/clientTools/singleFindAndReplaceImpl.ts

core/tools/definitions/multiEdit.ts

core/config/profile/doLoadConfig.ts

gui/src/redux/thunks/streamNormalInput.ts

core/tools/index.ts

github-actions · 2025-08-20T23:40:47Z

Code Review Summary

✅ Strengths

Architecture: The PR implements a well-designed strategy to introduce new edit tools (singleFindAndReplace and multiEdit) while maintaining backward compatibility with the existing editFile tool
Model-Based Tool Selection: Smart routing of tools based on model capabilities (Claude and GPT-5 get multiEdit, others get singleFindAndReplace)
Test Coverage: Comprehensive test suites for both new client tool implementations with good edge case coverage
Validation: Strong input validation and error handling with clear error messages
Atomic Operations: multiEdit tool ensures all edits succeed or none are applied, preventing partial file updates

⚠️ Issues Found

High

Model Name Matching Logic: The model name matching in core/tools/index.ts uses simple string contains checks (modelName?.includes("claude") || modelName?.includes("gpt-5")). This could incorrectly match model names like "claude-instant" or custom models containing these strings. Consider using more precise model name patterns or a whitelist approach.

Medium

Missing Integration Tests: While unit tests are comprehensive, there are no integration tests verifying the end-to-end flow from tool invocation through the IDE messenger to file modification
Incomplete Tool Migration: The old searchAndReplaceInFileTool is commented as "CURRENTLY NOT USED" but the code and tests are still present. This creates confusion about which tools are active

Low

Inconsistent Tool Descriptions: The multiEditTool description mentions it can create new files with empty old_string, but this behavior isn't clearly documented in the singleFindAndReplaceTool
Missing Environment Variable: The isRemote parameter is being passed but there's no clear documentation about how remote environments affect tool availability

💡 Suggestions

Model Configuration: Consider moving model-specific tool assignments to configuration rather than hardcoding them. This would allow easier updates as new models are released
Deprecation Strategy: Add clear deprecation notices to the old searchAndReplaceInFile tool and create a migration guide for users
Performance Optimization: For multiEdit, consider adding a dry-run mode to validate all edits before applying any changes
Documentation: Add examples to the tool descriptions showing common use cases like file creation, bulk renaming, and complex refactoring

🚀 Overall Assessment

APPROVE

This PR successfully introduces powerful new editing capabilities with a thoughtful migration strategy. The code quality is high with good test coverage and error handling. The issues identified are mostly about configuration flexibility and code cleanup rather than functional problems. The new tools provide a better user experience, especially for Claude models that can leverage the more sophisticated multiEdit tool.

💡 To request a new review, comment @continue-general-review

cubic-dev-ai

3 issues found across 16 files

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

gui/src/util/clientTools/multiEditImpl.ts

gui/src/util/clientTools/singleFindAndReplaceImpl.ts

core/tools/index.ts

cubic-dev-ai

3 issues found across 23 files

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

gui/src/pages/gui/ToolCallDiv/FunctionSpecificToolCallDiv.tsx

gui/src/util/clientTools/multiEditImpl.ts

feat: diff UI for find and replace tools

RomneyDa · 2025-08-25T20:16:36Z

gui/src/pages/gui/ToolCallDiv/FindAndReplace.tsx

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:16:46Z

gui/src/pages/gui/ToolCallDiv/FindAndReplace.test.tsx

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:17:03Z

gui/package.json

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:18:04Z

gui/src/components/StyledMarkdownPreview/StepContainerPreToolbar/ApplyActions.tsx

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:18:11Z

gui/src/components/StyledMarkdownPreview/StepContainerPreToolbar/FileInfo.tsx

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:18:48Z

gui/src/pages/gui/ToolCallDiv/FunctionSpecificToolCallDiv.tsx

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:18:56Z

gui/src/redux/slices/sessionSlice.ts

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:19:04Z

gui/src/pages/gui/ToolCallDiv/index.tsx

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:19:12Z

gui/src/redux/thunks/enhanceParsedArgs.ts

approved by tomasz on #7367

RomneyDa · 2025-08-25T20:19:47Z

gui/src/redux/thunks/streamNormalInput.ts

@@ -297,6 +254,19 @@ export const streamNormalInput = createAsyncThunk<
    const newState = getState();
    const toolSettings = newState.ui.toolSettings;
    const allToolCallStates = selectCurrentToolCalls(newState);
+
+    await Promise.all(


approved by tomasz on #7367

core/tools/definitions/singleFindAndReplace.ts

gui/src/util/clientTools/findAndReplaceUtils.ts

tingwai

Thanks for addressing comments!

sestinj · 2025-08-25T23:18:50Z

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: multi edit and single search and replace tools

d6ed405

RomneyDa requested a review from a team as a code owner August 20, 2025 23:39

RomneyDa requested review from tingwai and removed request for a team August 20, 2025 23:39

github-project-automation bot moved this to Todo in Issues and PRs Aug 20, 2025

github-project-automation bot added this to Issues and PRs Aug 20, 2025

dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 20, 2025

github-actions bot reviewed Aug 20, 2025

View reviewed changes

cubic-dev-ai bot reviewed Aug 20, 2025

View reviewed changes

gui/src/util/clientTools/multiEditImpl.ts Outdated Show resolved Hide resolved

gui/src/util/clientTools/singleFindAndReplaceImpl.ts Outdated Show resolved Hide resolved

core/tools/index.ts Show resolved Hide resolved

RomneyDa added 3 commits August 20, 2025 17:18

feat: UIs and add single replace to default tools

efa6328

fix: tests and prettier

54c16a3

fix: prettier issues

9b0b581

RomneyDa marked this pull request as draft August 22, 2025 01:09

RomneyDa marked this pull request as ready for review August 22, 2025 18:45

cubic-dev-ai bot reviewed Aug 22, 2025

View reviewed changes

gui/src/pages/gui/ToolCallDiv/FunctionSpecificToolCallDiv.tsx Outdated Show resolved Hide resolved

gui/src/util/clientTools/multiEditImpl.ts Outdated Show resolved Hide resolved

gui/src/util/clientTools/multiEditImpl.ts Outdated Show resolved Hide resolved

RomneyDa added 8 commits August 22, 2025 12:36

merge: main

be0c0d5

fix: handle apply error for multi/single edit tools

832b2d6

feat: unify edit tool apply handling

393c06f

fix: address bot feedback

3b6a290

fix: find and replace utils

4f18953

fix: gui tests for edit tools

c3ad86f

feat: UI for diff tools

469c0c8

test: find and replace ui tests

07c3930

RomneyDa mentioned this pull request Aug 24, 2025

feat: diff UI for find and replace tools #7367

Merged

RomneyDa and others added 3 commits August 23, 2025 18:31

chore: cleanup console logs

0208969

fix: cubic feedback

56b7195

Merge pull request #7367 from continuedev/dallin/diff-UI

ff931ec

feat: diff UI for find and replace tools

RomneyDa commented Aug 25, 2025

View reviewed changes

tingwai reviewed Aug 25, 2025

View reviewed changes

core/tools/definitions/singleFindAndReplace.ts Show resolved Hide resolved

gui/src/util/clientTools/findAndReplaceUtils.ts Outdated Show resolved Hide resolved

fix: make search and replace edit copy less confusing

fc93a2e

tingwai approved these changes Aug 25, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 25, 2025

dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 25, 2025

RomneyDa merged commit b25d4af into main Aug 25, 2025
68 of 84 checks passed

RomneyDa deleted the dallin/search_and_replace_makeover branch August 25, 2025 22:01

github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 25, 2025

github-actions bot locked and limited conversation to collaborators Aug 25, 2025

github-actions bot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Aug 25, 2025

sestinj added the released label Aug 25, 2025

feat: multi edit and single search and replace tools #7267

feat: multi edit and single search and replace tools #7267

Conversation

RomneyDa commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by cubic

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2025

Code Review Summary

✅ Strengths

⚠️ Issues Found

High

Medium

Low

💡 Suggestions

🚀 Overall Assessment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tingwai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sestinj commented Aug 25, 2025

Uh oh!

Uh oh!

RomneyDa commented Aug 20, 2025 •

edited

Loading