-
Notifications
You must be signed in to change notification settings - Fork 4
Integrate scan_fmt_scxml crate with SCXML parsing logic #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Dear @pouyapd thank you for the PR. There are a few issues with it:
Please fix the above issues so that I can move on with the review process. |
Signed-off-by: pouyapd <[email protected]>
Signed-off-by: pouyapd <[email protected]>
…go warnings Signed-off-by: pouyapd <[email protected]>
|
Dear Professor, I have reviewed your feedback on this Pull Request. I have made the following corrections:
Thank you again for your clear feedback! Best regards, |
EnricoGhiorzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are issues with the scan_fmt_scxml/Cargo.toml file that prevent building. Please fix these so that I can move on with the review.
scan_fmt_scxml/Cargo.toml
Outdated
| @@ -0,0 +1,24 @@ | |||
| [package] | |||
| name = "scan_scxml" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name conflicts with the other scan_scxml. I suggest renaming your package and library crate as scan_fmt_scxml.
scan_fmt_scxml/Cargo.toml
Outdated
| edition = "2024" | ||
|
|
||
| [lib] | ||
| name = "scan_scxml" # The name of the target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous comment.
scan_fmt_scxml/Cargo.toml
Outdated
| chumsky = "0.10.1" | ||
| csv = { workspace = true } | ||
| flate2 = { workspace = true } | ||
| scan_fmt_scxml = { path = "../scan_fmt_scxml" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A package cannot have itself as a dependency. You maybe wanted to import scan_scxml? Not sure it's needed anyway.
Signed-off-by: pouyapd <[email protected]>
|
Dear Professor, |
Signed-off-by: Atoosa Ebrahimabadi <[email protected]>
Signed-off-by: Andrea5456 <[email protected]>
Signed-off-by: Atoosa Ebrahimabadi <[email protected]>
EnricoGhiorzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear SCXML group, I have reviewed the PR and I found some issues:
- The code does not compile: there are issues on the
Cargo.tomlmanifests breaking the compilation. Did you forgot to include some commits maybe? - I made the code compile and run the tests with
cargo test. I found out that the tests inscxml_libdo not run because there is no associatedtest.rsfile. Please include such a file (you can take as example the relevant code in the other packages) so that your code can be automatically tested.
…onvince-project#36 feedback) Signed-off-by: pouyapd <[email protected]>
Signed-off-by: pouyapd <[email protected]>
EnricoGhiorzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still errors that are preventing build. One I pointed out. Another is the chumsky dependency being updated to 0.10 while the code is still using 0.9. Other errors are due, I believe, to merging the main branch into yours. The main branch ofter gets breaking changes so I reccommend not to merge it (unless you make sure to also fix your code accordingly).
I recommend to not merge upstream main into your branch, and to make sure your code compiles. If your code is compiling locally, it means it is not aligned with the PR.
|
|
||
| [dependencies] | ||
| scan_core = { version = "0.1.0", path="../scan_core" } | ||
| scan_fmt_scxml = { path = "../scan_fmt_scxml" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this files are unnecessary (as you don't need to modify scan_scxml) and also break building, because the line was added twice. Please fix this.
…onvince-project#36 feedback) Signed-off-by: pouyapd <[email protected]>
…onvince-project#36 feedback) Signed-off-by: pouyapd <[email protected]>
This pull request integrates a new crate,
scan_fmt_scxml, to add SCXML parsing capabilities to the SCAN project.Changes include:
scan_fmt_scxmlcrate containing the SCXML parsing logic.scan_scxml/src/parser.rsto use thescan_fmt_scxmllibrary for parsing .scxml files.Cargo.tomlto includescan_fmt_scxmlin the workspace and dependencies.scan_scxml/Cargo.tomlto addscan_fmt_scxmlas a dependency for thescan_scxmlcrate.This allows SCAN to load models specified in the SCXML format.