Skip to content

DRAFT: Initial v2 upgrade attempt #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 33 commits into from
Closed

DRAFT: Initial v2 upgrade attempt #263

wants to merge 33 commits into from

Conversation

nateinaction
Copy link
Contributor

@nateinaction nateinaction commented Aug 22, 2025 •
edited
Loading

Description of your changes

Resolves #262

This PR upgrades provider-sql to crossplane v2 with new namespaced CRs

Added:

  • Namespaced MRs!
  • ClusterProviderConfig for referencing cluster scoped provider configs from namespaced resources

Changed:

  • apis, controllers and examples now have scoped subdirectories as cluster and namespaced
  • handwritten resource resolvers have been replaced with ones generated by angryjet

⚠️ Removed:

  • External Secret Store support is removed from ALL MRs (spec.publishConnectionDetailsTo is removed). This feature was alpha and it was decided to be removed from crossplane.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Only MySQL changes have been tested manually:

k get user.mysql.sql.crossplane.io
NAME                 READY   SYNCED   AGE
cluster-mysql-user   True    True     7s
k get users.mysql.sql.m.crossplane.io
NAME             READY   SYNCED   AGE
cpc-mysql-user   True    True     16s
ns-user          True    True     16s

@nateinaction nateinaction force-pushed the v2-ngay branch 2 times, most recently from c34fea0 to 67f2547 Compare August 26, 2025 17:47
fernandezcuesta and others added 27 commits September 9, 2025 13:42
@fernandezcuesta @tydanny
chore: remove duplicate entry of golangci version (crossplane-contrib…
670bd91 
…#236)

* chore: remove duplicate entry of golangci version

Signed-off-by: Jesús Fernández <[email protected]>

* chore: bump up versions for crossplane 1.20

Signed-off-by: Jesús Fernández <[email protected]>

* chore: restore changes

Signed-off-by: Jesús Fernández <[email protected]>

---------

Signed-off-by: Jesús Fernández <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@chlunde @tydanny
chore: Enable dependabot monthly updates (crossplane-contrib#234)
79353c1 
Monthly should be often enough for this project, we can cover security
updates separately.

I have ignored k8s.io packages as they should match what crossplane-runtime
uses.

Signed-off-by: Ty Christensen <[email protected]>
@dependabot @tydanny
chore: bump github.com/google/go-cmp from 0.6.0 to 0.7.0 (crossplane-…
bd953fe 
…contrib#250)

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-cmp
  dependency-version: 0.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ty Christensen <[email protected]>
@dependabot @tydanny
chore: bump github.com/DATA-DOG/go-sqlmock from 1.5.0 to 1.5.2 (cross…
c243b0d 
…plane-contrib#248)

Bumps [github.com/DATA-DOG/go-sqlmock](https://github.com/DATA-DOG/go-sqlmock) from 1.5.0 to 1.5.2.
- [Release notes](https://github.com/DATA-DOG/go-sqlmock/releases)
- [Commits](DATA-DOG/go-sqlmock@v1.5.0...v1.5.2)

---
updated-dependencies:
- dependency-name: github.com/DATA-DOG/go-sqlmock
  dependency-version: 1.5.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ty Christensen <[email protected]>
@chlunde @tydanny
Publish package to ghcr.io by using reusable workflows (crossplane-co…
7b40a9e 
…ntrib#243)

I've disabled the backport and commands workflow as backports
and patch releases are not something we're doing at the moment.

Signed-off-by: Ty Christensen <[email protected]>
@dependabot @tydanny
chore: bump github.com/lib/pq from 1.8.0 to 1.10.9 (crossplane-contri…
8c64a0c 
…b#247)

Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.8.0 to 1.10.9.
- [Release notes](https://github.com/lib/pq/releases)
- [Commits](lib/pq@v1.8.0...v1.10.9)

---
updated-dependencies:
- dependency-name: github.com/lib/pq
  dependency-version: 1.10.9
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ty Christensen <[email protected]>
@chlunde @tydanny
Relax MySQL Database schema, forProvider is optional (crossplane-cont…
99f341b 
…rib#255)

This was a breaking change which was not strictly required. Make the
field optional again so we don't cause any uneccesary breaking changes
for users upgrading from 0.7.0.

Thanks to @cm3brian for the report!

Fixes crossplane-contrib#241

Signed-off-by: Carl Henrik Lunde <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Update deps and generate
f485b25 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
All current apis to cluster dir
cdb8374 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Generate namespaced CRs
4665f1b 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Generate working
6e6c724 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Update cluster controllers for v2 and add namespaced controllers
3411bfb 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Fix make generate
cfcf5c2 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
bump golang to 1.24
bf04cce 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Add namespaced examples
068d37f 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Add namespaced resources to scheme
674627b 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Fix spelling
94c4dd1 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Add usage to ProviderConfigKinds
615a909 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Fix controller name
e0a9ade 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Fixing some issues
5443ffa 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
fix code generation
a7edf59 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
use namespace when fetching provider config
ba57249 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
make cluster provider config cluster scoped
772db6c 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
use angryjet generation for resolvers
bf77761 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
fix rebase issues
8528c8a 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
make cluster provider config cluster scoped
c495fa6 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
use angryjet generation for resolvers
07c0e42 
Signed-off-by: Ty Christensen <[email protected]>
nateinaction and others added 5 commits September 9, 2025 13:50
@nateinaction @tydanny
Add testing instructions to readme
8fa51d9 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction @tydanny
Add clusterproviderconfig to scheme
fc0fd15 
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
make cluster configs cluster scoped
85143b7 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
use common prover gathing and fix tests
e5823c5 
Signed-off-by: Ty Christensen <[email protected]>
@tydanny
fix linting issues
dd41d93 
Signed-off-by: Ty Christensen <[email protected]>
@nateinaction nateinaction mentioned this pull request Sep 10, 2025
Merged
2 tasks
@nateinaction
Copy link
Contributor Author

Opting for #267. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for v2 (Namespaced resources)
4 participants
@nateinaction @fernandezcuesta @chlunde @tydanny