-
Notifications
You must be signed in to change notification settings - Fork 81
Add Crossplane v2 support #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crossplane v2 support #267
Conversation
Signed-off-by: Ty Christensen <[email protected]> Signed-off-by: Nate Gay <[email protected]>
aba4194
to
4bce87e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I noticed a missing resolved, could you add that and run code generation?
Updates for integration tests with is in this branch: https://github.com/chlunde/provider-sql/commits/crossplane-v2/ (some more cleanup would be nice) I'm not sure why the pg password doesn't properly reset when running two pg tests. Feel free to take whatever you want from that branch. Maybe we should test some variants of provider configs too (at least manually). |
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Carl Henrik Lunde <[email protected]>
Orphan has been replaced with managementPolicies, so remove that Signed-off-by: Carl Henrik Lunde <[email protected]>
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Nate Gay <[email protected]>
Signed-off-by: Nate Gay <[email protected]>
Description of your changes
Resolves #262
More work shown in #263
This PR upgrades
provider-sql
to crossplane v2 with new namespaced CRsAdded:
ClusterProviderConfig
for referencing cluster scoped provider configs from namespaced resourcesChanged:
apis
,controllers
andexamples
now have scoped subdirectories ascluster
andnamespaced
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
E2E tests pass:
Testing creating MySQL users with the various types of provider configs:
Legacy cluster provider config:
Modern cluster and namespaced provider configs: