-
Notifications
You must be signed in to change notification settings - Fork 5
fix accessibility violations on react button tests #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cypress-design
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-design
|
| Branch Review |
mabel/fix-accessibility-violation
|
| Run status |
|
| Run duration | 02m 08s |
| Commit |
|
| Committer | mabela416 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
1
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
0%
|
|
|---|---|
|
|
9
|
|
|
0
|
Accessibility
94.24%
|
|
|---|---|
|
|
0 critical
1 serious
3 moderate
0 minor
|
|
|
8
|
|
@mabela416 Can you attach a screenshots of visual changes that are created by this pr? |
This change only affects the color of the size (48, 40, 32, etc) text next to the buttons in the Before
Now
|
cypress-design
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-design
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 06m 31s |
| Commit |
|
| Committer | mabela416 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
1
|
|
|
0
|
|
|
6
|
|
|
229
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
6.76%
|
|
|---|---|
|
|
329
|
|
|
25
|
Accessibility
99.4%
|
|
|---|---|
|
|
0 critical
2 serious
0 moderate
1 minor
|
|
|
28
|
Tests for review
components/Button/react/ButtonReact.cy.tsx • 1 failed test • Component
| Test | Artifacts | |
|---|---|---|
| > renders variants disabled |
Test Replay
Screenshots
|
|
components/Menu/react/MenuReact.cy.tsx • 1 flaky test • Component
| Test | Artifacts | |
|---|---|---|
| > renders |
Test Replay
Screenshots
|
|






This test is failing because of an accessibility violation in the html we set up to test the Buttons in React. I updated the text for certain variants to be
text-gray-900instead oftext-gray-700Note: this change only affects the actual test set up for the
ButtonReact.cy.tsxtest