Skip to content

Conversation

@mabela416
Copy link
Contributor

@mabela416 mabela416 commented Oct 10, 2025

This test is failing because of an accessibility violation in the html we set up to test the Buttons in React. I updated the text for certain variants to be text-gray-900 instead of text-gray-700

Note: this change only affects the actual test set up for the ButtonReact.cy.tsx test

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: 560d197

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cypress-design Ready Ready Preview Oct 10, 2025 7:01pm

@cypress
Copy link

cypress bot commented Oct 10, 2025

cypress-design    Run #3198

Run Properties:  status check passed Passed #3198  •  git commit 41772ce378 ℹ️: Merge 560d197674ac52a05b74b2dec4f7792b3730766f into 352f217b3c01b193de4558bf6b78...
Project cypress-design
Branch Review mabel/fix-accessibility-violation
Run status status check passed Passed #3198
Run duration 02m 08s
Commit git commit 41772ce378 ℹ️: Merge 560d197674ac52a05b74b2dec4f7792b3730766f into 352f217b3c01b193de4558bf6b78...
Committer mabela416
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 9  
  Tested elements 0  
Accessibility  94.24%
  Failed rules  0 critical   1 serious   3 moderate   0 minor
  Failed elements 8  

@emilmilanov
Copy link
Contributor

@mabela416 Can you attach a screenshots of visual changes that are created by this pr?

@mabela416 mabela416 changed the title fix accessibility violations on react button docs fix accessibility violations on react button tests Oct 14, 2025
@mabela416
Copy link
Contributor Author

@mabela416 Can you attach a screenshots of visual changes that are created by this pr?

This change only affects the color of the size (48, 40, 32, etc) text next to the buttons in the ButtonReact.cy.tsx test. Before for certain variants it was text-gray-700 and now it is text-gray-900

Before

image image image

Now

image image image

@mabela416 mabela416 merged commit b34d23c into main Oct 14, 2025
50 of 55 checks passed
@mabela416 mabela416 deleted the mabel/fix-accessibility-violation branch October 14, 2025 16:02
@cypress
Copy link

cypress bot commented Oct 14, 2025

cypress-design    Run #3221

Run Properties:  status check failed Failed #3221  •  git commit b34d23ca4f: fix accessibility violations on react button docs (#625)
Project cypress-design
Branch Review main
Run status status check failed Failed #3221
Run duration 06m 31s
Commit git commit b34d23ca4f: fix accessibility violations on react button docs (#625)
Committer mabela416
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 6
Tests that passed  Passing 229
View all changes introduced in this branch ↗︎
UI Coverage  6.76%
  Untested elements 329  
  Tested elements 25  
Accessibility  99.4%
  Failed rules  0 critical   2 serious   0 moderate   1 minor
  Failed elements 28  

Tests for review

Failed  components/Button/react/ButtonReact.cy.tsx • 1 failed test • Component

View Output

Test Artifacts
> renders variants disabled Test Replay Screenshots
Flakiness  components/Menu/react/MenuReact.cy.tsx • 1 flaky test • Component

View Output

Test Artifacts
> renders Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants