Migrate from TinyMCE to TipTap #1349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
=======================================
Coverage 80.10% 80.10%
=======================================
Files 70 70
Lines 4755 4755
=======================================
Hits 3809 3809
Misses 946 946 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/migrate-to-tiptap
|
| Run status |
|
| Run duration | 07m 33s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
358
|
| View all changes introduced in this branch ↗︎ | |
|
Hey @jdbocarsly, as discussed last week in the PR using QuillJS, cross-referencing (should) work in this PR if you want to test it. I think I'm going to abandon QuillJS in favour of Tiptap to replace TinyMCE. |
|
This is really slick! Thanks for doing this. The @ tagging is really smooth, and I really like the mermaid editor! A few notes:
|
ml-evs
force-pushed
the
bc/migrate-to-tiptap
branch
from
75b87c4 to
015ce86
Compare
|
ml-evs
reviewed
Sep 30, 2025
There was a problem hiding this comment.
Looking really nice @BenjaminCharmes! As discussed, let's get this merged with some final tweaks and things to think about:
- Either write a formal test or just check what an old complex (e.g., colours, tables, images) TinyMCE description looks like when rendered here
- Make sure the cross-ref item search can also search for equipment (may need future API change)
- Investigate image plugin for tiptap for uploading images
- Tweak button for equations to say f(x) (or whatever)
- Enable markdown preview/toggle either in this PR or future
This was referenced Sep 30, 2025
Add padding Handle clickoutside while select text Add prosemirror-view to resolutions Re-add data-testid to Tiptap editor Update cypress run pre-commit local Update cypress Update cypress manual pre-commit modif manual pre-commit modif Update MarkdownToggle.js Update MarkdownToggle.js Remove 'blur' causing issue with toggle markdown
BenjaminCharmes
force-pushed
the
bc/migrate-to-tiptap
branch
from
97a3356 to
8fb22c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1232
Duplicate of the PR #1343 , but this one uses Tiptap and supports all the basic features of TinyMCE.
Perhaps it would be easier to merge the two to compare Quill and Tiptap? After trying both, TipTap seems more robust for the long term.
This PR already support:
TinyMCEInline.vue