-
Notifications
You must be signed in to change notification settings - Fork 22
Add "equipment" item type #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e3e2d0f
add minimal model for instruments
jdbocarsly 22090d0
add backend routes for equipment
jdbocarsly cab0ed4
frontend for equipment table page, "new equipment" modal functionali…
jdbocarsly be6d3ec
turn on emojis in tinymce fields :grin:
jdbocarsly 90f5540
fix bug in DataBlockBase where the block type wasn't displayed properly
jdbocarsly 64483d4
Clean up and fix typos in equipment routes based on code review
jdbocarsly 80097d3
allow all logged-in users to see all equipment
jdbocarsly 8c26944
adjust EquipmentTable columns and add delete buttons
jdbocarsly b59c7b9
specify which types are included in the equipment table using EQUIPME…
jdbocarsly d4ddf84
add contact information field to the Equipment model and frontend
jdbocarsly 43241d2
remove creators from new equipment entries so they are visible for al…
jdbocarsly 47f0ab3
add python tests for equipment
jdbocarsly 56fbc5b
fix typos in starting material python tests
jdbocarsly 804e8c5
cleanup and improve scoping of ids for inputs across app
jdbocarsly b53f2da
clean up e2e tests, and update them to better scope actions to within…
jdbocarsly 8769345
Cleanup and update batchSampleFeature.js e2e test, remove unnecessary…
jdbocarsly b04b86a
remove location field from CreateEquipmentModal.vue
jdbocarsly 3c567c4
add e2e tests for equipment
jdbocarsly dc831b3
remove unnecessary within() calls from cypress tests
jdbocarsly 259f0ae
turn on batchSampleFeature.cy.js e2e tests, and enable equipment test…
jdbocarsly 770741b
remove cypress spec list from ci.yml so that all specs run
jdbocarsly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
from typing import Optional | ||
|
||
from pydantic import Field | ||
|
||
from pydatalab.models.items import Item | ||
|
||
|
||
class Equipment(Item): | ||
"""A model for representing an experimental sample.""" | ||
|
||
type: str = Field("equipment", const="equipment", pattern="^equipment$") | ||
|
||
serial_numbers: Optional[str] | ||
"""A string describing one or more serial numbers for the instrument.""" | ||
jdbocarsly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
manufacturer: Optional[str] | ||
"""The manufacturer of this piece of equipment""" | ||
|
||
location: Optional[str] | ||
"""Place where the equipment is located""" | ||
|
||
contact: Optional[str] | ||
"""Contact information for equipment (e.g., email address or phone number).""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.