Add "equipment" item type #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbocarsly
changed the title
Passing run #1401 ↗︎
Details:
Review all test suite changes for PR #531 ↗︎ |
|||||||||||||||
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
from
32451bd to
c824e86
Compare
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
3 times, most recently
from
e82593e to
c494426
Compare
ml-evs
reviewed
Feb 12, 2024
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
from
72a5b3d to
a4bf1a7
Compare
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
3 times, most recently
from
da343ed to
86563af
Compare
jdbocarsly
changed the title
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
from
f20d792 to
1806772
Compare
ml-evs
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Code wise, this is looking great!
Dare I suggest adding some API and e2e tests? 😅
I guess the large outstanding thing to discuss is how to capture the relationships between equipment and items (and blocks) which I know has been started in #565
How dare you |
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
from
1806772 to
de4930a
Compare
This was referenced Mar 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
+ Coverage 66.25% 66.45% +0.19%
==========================================
Files 60 61 +1
Lines 3586 3610 +24
==========================================
+ Hits 2376 2399 +23
- Misses 1210 1211 +1
|
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
3 times, most recently
from
a60a11e to
a65162f
Compare
…y, and EquipmentInformation fix a typo in html of sample table
Co-authored-by: Matthew Evans <[email protected]> Co-authored-by: Matthew Evans <[email protected]>
…NT_TABLE_TYPES, to match new style used for Sample and Inventory tables
…l users within a deployment
… specific areas of the app
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
from
a65162f to
ac4d847
Compare
ml-evs
reviewed
Mar 30, 2024
add autogenerated equipment schema
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
from
fe1202d to
9946624
Compare
jdbocarsly
force-pushed
the
jdb/add-equipment
branch
from
b88173e to
259f0ae
Compare
This was referenced Apr 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
equipmenttype, which can be used for laboratory instruments or other equipment. For now, it behaves like any other item and supports all the blocks supported by samples or cells. It is envisioned that comment blocks, media blocks, and attached files can be used to store maintenace information, manuals, usage logs, etc.In the future, some more advanced dashboard features, linking to filesystems, etc. would be nice.
[ ] Make frontend table for equipment (fancy)(defer to future PR)[ ] Make it possible to link individual measurements to equipment(defer to future PR)Space is present in the frontend for maintainers and collections to be listed, but these are currently not implemented.
In addition, this PR also contains some bug fixes and some tinymce fixes to prepare for more free-form linking #565.