Skip to content

fix(vd): fail with error on insufficient PVC size #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

loktev-d
Copy link
Contributor

Description

When importing VirtualDisk from VirtualImage or ClusterVirtualImage, if PVC size is insufficient, set phase to Failed with error message in Ready condition instead of hanging in Pending without errors.

Why do we need it, and what problem does it solve?

To provide clear, immediate feedback to users when a VD configuration error occurs during import from a VI or a CVI

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vd
type: fix
summary: Fail with error on insufficient PVC size

@loktev-d loktev-d added this to the v0.24.0 milestone Jul 31, 2025
@loktev-d loktev-d marked this pull request as draft July 31, 2025 09:21
When importing VirtualDisk from VirtualImage or ClusterVirtualImage, if PVC size is insufficient, set phase to Failed with error message in Ready condition instead of hanging in Pending without errors.

Signed-off-by: Daniil Loktev <[email protected]>
@loktev-d loktev-d force-pushed the fix/vd/insufficient-pvc-size-error branch from c670206 to d743031 Compare July 31, 2025 09:23
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Jul 31, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jul 31, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jul 31, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Jul 31, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jul 31, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jul 31, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Jul 31, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jul 31, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jul 31, 2025
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Aug 1, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 1, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 1, 2025
@loktev-d loktev-d marked this pull request as ready for review August 1, 2025 10:06
@loktev-d loktev-d merged commit 4b8ae4d into main Aug 4, 2025
218 of 223 checks passed
@loktev-d loktev-d deleted the fix/vd/insufficient-pvc-size-error branch August 4, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants