Replace libdparse with dmd as a library in static code analysis #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with dmd (dlang-community#17) * replace libdparse in objectconst functionality + unittests integration with dmd * updated dmd * run tests * use templates * visit aggregate declaration * updated dmd * solve linter seg fault * get rid of dup + refactor * fix typo
* replace libdparse in delete check * delete comment
* Update README * Add dmd-as-a-library submodule (dlang-community#2) * Add GH Actions build script (dlang-community#4) * Removed libdparse from imports print functionality (dlang-community#3) * Fix failing tester + add unittest for imports (dlang-community#7) * Add style checker (dlang-community#9) * Update action to build dlang fork * Fix linter errors * Add dmd dependencies to dub.json * Add dmd dependencies to build.bat * Replace libdparse in enum array functionality * replace libdparse in objectconst functionality + unittests integration with dmd (dlang-community#17) * replace libdparse in objectconst functionality + unittests integration with dmd * updated dmd * run tests * use templates * visit aggregate declaration * updated dmd * solve linter seg fault * get rid of dup + refactor * fix typo * update dmd to latest version Co-authored-by: RazvanN7 <[email protected]> Co-authored-by: Eduard Staniloiu <[email protected]>
* update dmd * update dmd
* replace libdparse in imports sortedness visitor * minor refactor
* Replace libdparse with DMD in AllManCheck * Test assertAnalyzerDmd without writing to file * Revert "Test assertAnalyzerDmd without writing to file" This reverts commit 9f50f38a11d97df960c05d5a128059b13e7dcab4. * Fix windows ci bug --------- Co-authored-by: Eduard Staniloiu <[email protected]>
…ty#128) * Replace libdparse with DMD in IfConstraintsIndentCheck * Fix evil segfault bug * Remove Issue#829 unit test * Properly detect issue
* Delete libdparse unit test assertion function * Delete unused libdparse visitors from base.d * Improve StaticIfElse warning location * Improve FunctionAttributeCheck warning location * Switch to DMD flow for listing autofixes * Extract dmd analyzer selection in a separate function * Make getName() method in BaseAnalyzerDmd public * Fix offsets in integration test json * Improve StyleChecker warning location * Enable integration tests in CI * Fix Autofix flow * Remove & comment dead code * Remove dead code from autofix unit test * Remove dead code * Remove dead code from autofix.d * Clean up code in helpers.d * Clean up code in run.d and migrate StatsCollector to dmd * Fix reading code from stdin * Return if errors are found in analysis flows * Remove dead code * Check for Windows line terminators in integration tests
|
@rikkimax Any idea why the pipeline fails? |
|
why are all the error ranges being removed and replaced with just a line-based test? That will reduce usability of auto fixes and degrade IDE integration quite a lot. I think having proper start and end locations of warnings is pretty essential for D-Scanner and changing the expected behavior / changing the tests there is kinda a breaking change. |
A quick look over the missing symbols error, shows that you're compiling dmd's glue code. You want the |
|
@rikkimax I was asking more about the jobs that don't even get to the build phase. I'll also take a look and fix dub compilation. |
|
I have no idea what upterm.dev is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a follow-up of #964 to hopefully get it merged.