Replace libdparse with dmd as a library in static code analysis

.editorconfig

@@ -22,4 +22,4 @@ dfmt_template_constraint_style = conditional_newline_indent
 
 [*.yml]
 indent_style = space
-indent_size = 2
+indent_size = 2

.github/workflows/default.yml

@@ -87,6 +87,10 @@ jobs:
            submodules: 'recursive'
            fetch-depth: 0
 
+      # Uncomment to get a ssh connection inside the GH Actions runner
+      - name: Setup upterm session
+        uses: lhotari/action-upterm@v1
+
       # Install the host compiler (DMD or LDC)
       # Also grabs DMD for GDC to include dub + rdmd
       - name: Install ${{ matrix.compiler.version }}
@@ -102,6 +106,10 @@ jobs:
           sudo apt-get install gdc-12 -y
           gdc-12 --version
 
+      - name: Setup upterm session
+        if: ${{ matrix.build.type == 'dub' && matrix.host == 'ubuntu-22.04'}}
+        uses: lhotari/action-upterm@v1
+
       # Compile D-Scanner and execute all tests without dub
       - name: Build and test without dub
         if: ${{ matrix.build.type == 'make' }}
@@ -114,7 +122,8 @@ jobs:
             ./build.bat
             ./build.bat test
           else
-            make "-j$(nproc)" all test
+            NUM_PROC=$(nproc || getconf _NPROCESSORS_ONLN || 1)
+            make "-j$((NUM_PROC / 2))" all test
           fi
 
       # Compile D-Scanner and execute all tests using a specific dependency version
@@ -159,10 +168,20 @@ jobs:
           "./bin/dscanner$EXE" --styleCheck -f "$FORMAT" src
 
       - name: Integration Tests
-        run: ./it.sh
+        run: |
+          if [ "$RUNNER_OS" == "Windows" ]; then
+            ./it.sh Windows
+          else
+            ./it.sh Unix
+          fi
         working-directory: tests
         shell: bash
 
+      - name: Run style checks
+        if: ${{ matrix.compiler.dmd == 'dmd' && matrix.build.type == 'make' }}
+        run: |
+          make style
+
       # Parse phobos to check for failures / crashes / ...
       - name: Checkout Phobos
         uses: actions/checkout@v4
@@ -171,7 +190,7 @@ jobs:
           path: phobos
 
       - name: Apply D-Scanner to Phobos
-        if:  ${{ matrix.build.version != 'min libdparse'}} # Older versions crash with "Invalid UTF..."
+        if: ${{ matrix.build.version != 'min libdparse'}} # Older versions crash with "Invalid UTF..."
         working-directory: phobos
         shell: bash
         run: |

.gitignore

@@ -11,6 +11,9 @@
 # Sublime Text 2
 *.sublime-workspace
 
+# Idea stuff
+.idea/
+
 # Subversion
 .svn/
 

.gitmodules

@@ -17,3 +17,6 @@
 [submodule "DCD"]
 	path = DCD
 	url = https://github.com/dlang-community/DCD.git
+[submodule "dmd"]
+	path = dmd
+	url = [email protected]:dlang/dmd.git

README.md

@@ -7,7 +7,15 @@
 D-Scanner is a tool for analyzing D source code
 
 ### Building and installing
-First make sure that you have all the source code. Run ```git submodule update --init --recursive```
+
+First, make sure that you have fetched the upstream: [email protected]:dlang-community/D-Scanner.git
+
+```
+git remote add upstream [email protected]:dlang-community/D-Scanner.git
+git fetch upstream
+```
+
+Secondly, make sure that you have all the source code. Run ```git submodule update --init --recursive```
 after cloning the project.
 
 To build D-Scanner, run ```make``` (or the build.bat file on Windows).

build.bat

@@ -18,8 +18,8 @@ if %githashsize% == 0 (
 	move /y bin\githash_.txt bin\githash.txt
 )
 
-set DFLAGS=-O -release -Jbin %MFLAGS%
-set TESTFLAGS=-g -w -Jbin
+set DFLAGS=-O -release -version=StdLoggerDisableWarning -version=CallbackAPI -version=DMDLIB -version=MARS -version=NoBackend -version=NoMain -Jbin -Jdmd -Jdmd\compiler\src\dmd\res %MFLAGS%
+set TESTFLAGS=-g -w -version=StdLoggerDisableWarning -version=CallbackAPI -version=DMDLIB -version=MARS -version=NoBackend -version=NoMain -Jbin -Jdmd -Jdmd\compiler\src\dmd\res
 set CORE=
 set LIBDPARSE=
 set STD=
@@ -29,6 +29,44 @@ set DSYMBOL=
 set CONTAINERS=
 set LIBDDOC=
 
+set DMD_FRONTEND_DENYLIST=^
+	dmd\compiler\src\dmd\mars.d^
+	dmd\compiler\src\dmd\dmsc.d^
+	dmd\compiler\src\dmd\e2ir.d^
+	dmd\compiler\src\dmd\eh.d^
+	dmd\compiler\src\dmd\glue.d^
+	dmd\compiler\src\dmd\iasmdmd.d^
+	dmd\compiler\src\dmd\irstate.d^
+	dmd\compiler\src\dmd\lib.d^
+	dmd\compiler\src\dmd\libelf.d^
+	dmd\compiler\src\dmd\libmach.d^
+	dmd\compiler\src\dmd\libmscoff.d^
+	dmd\compiler\src\dmd\libomf.d^
+	dmd\compiler\src\dmd\objc_glue.d^
+	dmd\compiler\src\dmd\s2ir.d^
+	dmd\compiler\src\dmd\scanelf.d^
+	dmd\compiler\src\dmd\scanmach.d^
+	dmd\compiler\src\dmd\scanmscoff.d^
+	dmd\compiler\src\dmd\scanomf.d^
+	dmd\compiler\src\dmd\tocsym.d^
+	dmd\compiler\src\dmd\toctype.d^
+	dmd\compiler\src\dmd\tocvdebug.d^
+	dmd\compiler\src\dmd\toobj.d^
+	dmd\compiler\src\dmd\todt.d^
+	dmd\compiler\src\dmd\toir.d
+
+set DMD_FRONTEND_SRC=
+for %%x in (dmd\compiler\src\dmd\common\*.d) do set DMD_FRONTEND_SRC=!DMD_FRONTEND_SRC! %%x
+for %%x in (dmd\compiler\src\dmd\root\*.d) do set DMD_FRONTEND_SRC=!DMD_FRONTEND_SRC! %%x
+for %%x in (dmd\compiler\src\dmd\visitor\*.d) do set DMD_FRONTEND_SRC=!DMD_FRONTEND_SRC! %%x
+for %%x in (dmd\compiler\src\dmd\mangle\*.d) do set DMD_FRONTEND_SRC=!DMD_FRONTEND_SRC! %%x
+for %%x in (dmd\compiler\src\dmd\*.d) do (
+    echo "%DMD_FRONTEND_DENYLIST%" | findstr /i /c:"%%x" >nul
+    if errorlevel 1 (
+        set "DMD_FRONTEND_SRC=!DMD_FRONTEND_SRC! %%x"
+    )
+)
+
 for %%x in (src\dscanner\*.d) do set CORE=!CORE! %%x
 for %%x in (src\dscanner\analysis\*.d) do set ANALYSIS=!ANALYSIS! %%x
 for %%x in (libdparse\src\dparse\*.d) do set LIBDPARSE=!LIBDPARSE! %%x
@@ -45,14 +83,62 @@ for %%x in (containers\src\containers\internal\*.d) do set CONTAINERS=!CONTAINER
 if "%1" == "test" goto test_cmd
 
 @echo on
-%DC% %MFLAGS% %CORE% %STD% %LIBDPARSE% %LIBDDOC% %ANALYSIS% %INIFILED% %DSYMBOL% %CONTAINERS% %DFLAGS% -I"libdparse\src" -I"DCD\dsymbol\src" -I"containers\src" -I"libddoc\src" -I"libddoc\common\source" -ofbin\dscanner.exe
+%DC% %MFLAGS%^
+	%CORE%^
+	%STD%^
+	%LIBDPARSE%^
+	%LIBDDOC%^
+	%ANALYSIS%^
+	%INIFILED%^
+	%DSYMBOL%^
+	%CONTAINERS%^
+	%DMD_FRONTEND_SRC%^
+	%DFLAGS%^
+	-Ilibdparse\src^
+	-IDCD\dsymbol\src^
+	-Icontainers\src^
+	-Ilibddoc\src^
+	-Ilibddoc\common\source^
+	-Idmd\compiler\src^
+	-ofbin\dscanner.exe
 goto eof
 
 :test_cmd
 @echo on
 set TESTNAME="bin\dscanner-unittest"
-%DC% %MFLAGS% %STD% %LIBDPARSE% %LIBDDOC% %INIFILED% %DSYMBOL% %CONTAINERS% -I"libdparse\src" -I"DCD\dsymbol\src" -I"containers\src" -I"libddoc\src" -lib %TESTFLAGS% -of%TESTNAME%.lib
-if exist %TESTNAME%.lib %DC% %MFLAGS% %CORE% %ANALYSIS% %TESTNAME%.lib -I"src" -I"inifiled\source" -I"libdparse\src" -I"DCD\dsymbol\src" -I"containers\src" -I"libddoc\src" -I"libddoc\common\source" -unittest %TESTFLAGS% -of%TESTNAME%.exe
+%DC% %MFLAGS% ^
+	%STD%^
+	%LIBDPARSE%^
+	%LIBDDOC%^
+	%INIFILED%^
+	%DSYMBOL%^
+	%CONTAINERS%^
+	%DMD_FRONTEND_SRC%^
+	-I"libdparse\src"^
+	-I"DCD\dsymbol\src"^
+	-I"containers\src"^
+	-I"libddoc\src"^
+	-I"dmd\compiler\src"^
+	-I"dmd\compiler\src\dmd\res"^
+	%TESTFLAGS%^
+	-lib^
+	-of%TESTNAME%.lib
+if exist %TESTNAME%.lib %DC% %MFLAGS%^
+	%CORE%^
+	%ANALYSIS%^
+	%TESTNAME%.lib^
+	-I"src"^
+	-I"inifiled\source"^
+	-I"libdparse\src"^
+	-I"DCD\dsymbol\src"^
+	-I"containers\src"^
+	-I"libddoc\src"^
+	-I"libddoc\common\source"^
+	-I"dmd\compiler\src"^
+	-I"dmd\compiler\src\dmd\res"^
+	-unittest^
+	%TESTFLAGS%^
+	-of%TESTNAME%.exe
 if exist %TESTNAME%.exe %TESTNAME%.exe
 
 if exist %TESTNAME%.obj del %TESTNAME%.obj

changelog/dscanner.assert-without-message.dd

@@ -0,0 +1 @@
+Avoid checking `enforce` calls as it is phobos specific.

changelog/dscanner.comma-expression.dd

@@ -0,0 +1,3 @@
+Remove the check for comma expression check
+	e.g. (int a = 3, a + 7)
+This check is no longer necessary since comma expression have been removed from the D language.

changelog/dscanner.duplicate-attribute-check.dd

@@ -0,0 +1,2 @@
+Remove the check for duplicate attributes (@property, @safe, @trusted, @system, pure, nothrow).
+This check is no longer necessary since having duplicated attributes is now a compiler error.

changelog/dscanner.if-statements.dd

@@ -0,0 +1 @@
+Remove IfStatementCheck, as it has been disabled in 2015 due to false positives and untouched ever since then.

changelog/dscanner.struct-ctor-check.dd

@@ -0,0 +1,19 @@
+Remove the check regarding structs with no arguments constructors.
+
+The check is implemented in constructors.d and it warns against the usage
+of both constructors with all parameters with default values and constructors
+without any arguments, as this might be confusing. This scenario, for structs,
+is no longer D valid code and that's why it is being deprecated.
+
+Let's consider the following code:
+
+---
+struct Dog
+{
+	this() {}
+	this(string name = "doggie") {} // [warn]: This struct constructor can never be called with its default argument.
+}
+---
+
+D-Scanner would throw and error for this particular struct, but this code
+does not compile anymore hence this check is not needed anymore/

dub.json

@@ -15,7 +15,11 @@
     "dcd:dsymbol": ">=0.16.0-beta.2 <0.17.0",
     "inifiled": "~>1.3.1",
     "emsi_containers": "~>0.9.0",
-    "libddoc": "~>0.8.0"
+    "libddoc": "~>0.8.0",
+    "dmd": {
+      "repository": "git+https://github.com/dlang/dmd.git",
+      "version": "2d5cd3166b6cce7404c812a8f04156dc2f1108b5"
+    }
   },
   "targetPath" : "bin",
   "stringImportPaths" : [