Update to .NET 10 SDK and Arcade 10 #10075

joperezr · 2025-06-26T19:20:07Z

Description

Upgrading to use the .NET 10 SDK as well as Arcade 10. This will be helpful for some signing things we are doing plus taking advantage of new features in the SDK.

cc: @radical

Checklist

Is this feature complete?
- Yes. Ready to ship.
Are you including unit tests for the changes and scenario tests if relevant?
- No
Did you add public API?
- No
Does the change make any security assumptions or guarantees?
- No
Does the change require an update in our Aspire docs?
- No

joperezr · 2025-06-26T19:23:17Z

Setting as a draft as I'm queuing an internal build to see if official build works

eerhardt · 2025-06-26T19:31:10Z

Does this mean we could target net10.0 in the Aspire.Cli when publishing for AOT?

joperezr · 2025-06-26T19:36:47Z

Does this mean we could target net10.0 in the Aspire.Cli when publishing for AOT?

If we wanted to, yes 😃

…orted.

radical · 2025-06-26T21:47:19Z

We should also run an internal build, and a full azdo build with tests to validate this.

Copilot

Pull Request Overview

This PR upgrades the repository to use the .NET 10 SDK and Arcade 10, updating various build scripts, dependency configurations, and CI/CD pipeline templates.

Update target framework in csproj and global.json to net10.0 and update dotnet/arcade versions.
Modify build scripts (bash and PowerShell) to reflect new property names and parameters (e.g. DotNetBuild and DotNetBuildFromVMR).
Adjust dependency versions and SHA sums in files like Version.Details.xml and Versions.props, plus update NuGet and workflow settings for .NET10.

Reviewed Changes

Copilot reviewed 56 out of 58 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/GenerateTestSummary/GenerateTestSummary.csproj	Updated target framework from net9.0 to net10.0
global.json	Updated dotnet version and tool versions to .NET 10 SDK preview
eng/common/darc-init.sh	Updated package source URL for arcade services
eng/Version.Details.xml	Updated Arcade dependency versions and corresponding SHA sums
eng/common/build.sh	Changed MSBuild property names (DotNetBuildRepo → DotNetBuild) and added DotNetBuildFromVMR
Various workflow and CI templates	Updated pipelines and NuGet.config to reference .NET 10 sources

Comments suppressed due to low confidence (3)

eng/Version.Details.xml:153

Confirm that the updated dependency versions and SHA sums in Version.Details.xml are correct and that they match the intended Arcade 10 releases.

    </Dependency>

eng/common/build.sh:248

Ensure that updating the property name from 'DotNetBuildRepo' to 'DotNetBuild' and introducing 'DotNetBuildFromVMR' in build.sh is aligned with the rest of the build system to prevent configuration mismatches.

    /p:Build=$build \

davidfowl · 2025-06-26T23:57:59Z

Let’s gooo!

radical · 2025-06-27T01:21:17Z

New internal build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2738295&view=results
New full azdo build - https://dev.azure.com/dnceng-public/public/_build/results?buildId=1079575&view=results

radical · 2025-06-27T01:21:44Z

@joperezr would this work fine with VS/VS code?

`AzureFunctionsEndToEnd.AppHost.csproj : error NU1010: The following PackageReference items do not define a corresponding PackageVersion item: Aspire.Hosting.Azure.AppContainers. Projects using Central Package Management must declare PackageReference and PackageVersion items with matching names. For more information, visit https://aka.ms/nuget/cpm/gettingstarted `

…he corresponding test change

radical · 2025-06-27T05:23:42Z

Pushed some fixes. New internal build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2738413&view=results
New public azdo build - https://dev.azure.com/dnceng-public/public/_build/results?buildId=1079788&view=results

radical

LGTM, thank you!!

radical · 2025-06-27T07:53:54Z

@joperezr could you please review my additional changes to the PR before merging?

# Conflicts: # eng/clipack/Common.projitems

joperezr · 2025-06-27T20:37:40Z

eng/clipack/Common.projitems

      <AdditionalProperties Include="SelfContained=true" />
+
+      <!-- Windows pdb aren't really needed any more. See https://github.com/dotnet/arcade/issues/15724
+          As the pdb file is in the same location for all the RIDs it causes arcade's `_DeployPortableSymbolsToSymStore`


Isn't the right fix here to use different publish locations for different rids?

Publish directories are separate, and even the build dirs for the .dll but not for the .pdb! The .pdb files wouldn't be different per-rid so I think them being in the same location makes sense. We could fix this in arcade somehow, but apparently this whole thing (windows pdbs) is expected to be removed anyway. See dotnet/arcade#15724 and dotnet/arcade#15736 .

joperezr · 2025-06-27T20:38:46Z

eng/Versions.props

    <DotNetSdkPreviousVersionForTesting>8.0.406</DotNetSdkPreviousVersionForTesting>
    <!-- dotnet 10.0 versions for running tests - used for templates tests -->
-    <DotNetSdkNextVersionForTesting>10.0.100-preview.5.25277.114</DotNetSdkNextVersionForTesting>
+    <DotNetSdkCurrentVersionForTesting>9.0.200</DotNetSdkCurrentVersionForTesting>


Why is this not the current version? Should we rename the property instead?

These names are arbitrary really. We are following Previous, Current, Next to follow 3 active versions. 9.0 being Current works here allowing Previous=8.0 and Current=10.0.

I would use the same nomenclature as dotnet/runtime:
$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum)

Current = 10
Previous = 9
Minimum = 8

But maybe that only makes sense if we are on 10 as well. So maybe having Next be 10 until we are version 10...

joperezr · 2025-06-27T20:41:20Z

tests/Aspire.Templates.Tests/TemplateTestsBase.cs

            { templateName, extraArgs, TestSdk.Current, TestTargetFramework.Current, null },
            // Current SDK, Next TFM
-            { templateName, extraArgs, TestSdk.Current, TestTargetFramework.Next, "The current .NET SDK does not support targeting .NET 10.0" },
+            { templateName, extraArgs, TestSdk.Current, TestTargetFramework.Next, null },


Why not keep the current TFM actually be current (meaning 10.x) and then removing the expected error? (which is what I had) That way we are no validating that with a .NET 10 SDK you can build an aspire app targeting 10.

Can you elaborate on what is the missing case here, or the incorrect one?

eerhardt · 2025-06-27T21:36:31Z

tools/GenerateTestSummary/GenerateTestSummary.csproj

  <PropertyGroup>
    <OutputType>Exe</OutputType>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>


Do we want a property for this? like $(NetCoreAppCurrent)

We could, not sure if I'd block merging for this, so if this is the only remaining feedback I'd vote for doing this in the next PR

Update to .NET 10 SDK and Arcade 10

4e99ab0

github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jun 26, 2025

Update workflows to instal 10 sdk as well

0d6587c

joperezr added 3 commits June 26, 2025 12:43

Use latest released preview of the sdk instead

0a0e0c4

Add all necessary runtimes for template tests.

62f6ab5

Update tests for net10 now that targeting that from templates is supp…

6b49d70

…orted.

joperezr force-pushed the UpdateDotNet branch from acf395c to 6b49d70 Compare June 26, 2025 21:06

Update the testSummary project so that it also tagets net10

f5a801b

Adding sign info for js files

c5a685f

joperezr marked this pull request as ready for review June 26, 2025 22:25

Copilot AI review requested due to automatic review settings June 26, 2025 22:25

joperezr requested review from eerhardt and radical as code owners June 26, 2025 22:25

Copilot AI reviewed Jun 26, 2025

View reviewed changes

Add dotnet10 to the helix payload

5458b21

radical added 5 commits June 26, 2025 21:41

Merge remote-tracking branch 'origin/main' into UpdateDotNet

d3faa58

Merge remote-tracking branch 'origin/main' into UpdateDotNet

cce0b4f

Fix versions for current sdk to use 9.0 instead of 10.0, and revert t…

13cb134

…he corresponding test change

[tests] Add properties to control filtering tests

f2367dd

radical added 2 commits June 27, 2025 01:53

fix md linter

560722d

Fix race on windows

567a538

radical added the area-engineering-systems infrastructure helix infra engineering repo stuff label Jun 27, 2025

radical approved these changes Jun 27, 2025

View reviewed changes

radical added 2 commits June 27, 2025 14:50

Merge remote-tracking branch 'origin/main' into UpdateDotNet

261091f

Merge remote-tracking branch 'origin/main' into UpdateDotNet

4f45d40

# Conflicts: # eng/clipack/Common.projitems

joperezr commented Jun 27, 2025

View reviewed changes

address review feedback from @ joperezr

4fe6756

radical mentioned this pull request Jun 27, 2025

Failing test: Aspire.Hosting.Tests.DistributedApplicationTests.StartResourceForcesStart #10086

Open

eerhardt reviewed Jun 27, 2025

View reviewed changes

radical merged commit b6ede04 into main Jun 27, 2025
252 checks passed

radical deleted the UpdateDotNet branch June 27, 2025 22:34

MihuBot mentioned this pull request Jul 1, 2025

[✨ Triage] dotnet/aspire#10175 by JamesNK - NU1510 on my machine after .NET 10 SDK update MihuBot/runtime-utils#1190

Open

radical mentioned this pull request Jul 2, 2025

Revert update that moved back to Arcade 9 #10191

Closed

github-actions bot locked and limited conversation to collaborators Jul 28, 2025

Update to .NET 10 SDK and Arcade 10 #10075

Update to .NET 10 SDK and Arcade 10 #10075

Uh oh!

Conversation

joperezr commented Jun 26, 2025

Description

Checklist

Uh oh!

joperezr commented Jun 26, 2025

Uh oh!

eerhardt commented Jun 26, 2025

Uh oh!

joperezr commented Jun 26, 2025

Uh oh!

radical commented Jun 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

davidfowl commented Jun 26, 2025

Uh oh!

radical commented Jun 27, 2025

Uh oh!

radical commented Jun 27, 2025

Uh oh!

radical commented Jun 27, 2025

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

radical commented Jun 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants