Skip to content

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Sep 26, 2025

Description

This PR sets up performance measurements for iOS on CoreCLR. It adds a runtime build job and a sample app build step.

Successful build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2806045&view=results

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 08:42
@kotlarmilos kotlarmilos self-assigned this Sep 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR establishes performance measurement capabilities for iOS on CoreCLR by adding CoreCLR as a runtime option alongside the existing Mono support. The implementation includes parameter additions, runtime configuration options, and build pipeline integration.

  • Adds CoreCLR runtime support to iOS performance measurements
  • Configures iOS sample app to support both Mono and CoreCLR runtimes
  • Integrates CoreCLR iOS scenarios into the performance build pipeline

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/mono/sample/iOS/Makefile Adds runtime selection parameters (USE_MONO_RUNTIME, AOT) for CoreCLR support
eng/pipelines/performance/templates/perf-ios-scenarios-build-jobs.yml Introduces CoreCLR build job configuration for iOS performance scenarios
eng/pipelines/performance/templates/build-perf-sample-apps.yml Implements CoreCLR-specific iOS sample app build steps with interpreter mode

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some questions but looks good in general.

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but this looks good.

@kotlarmilos kotlarmilos enabled auto-merge (squash) October 2, 2025 12:53
@kotlarmilos
Copy link
Member Author

/ba-g #120317

@kotlarmilos kotlarmilos merged commit 2061030 into dotnet:main Oct 3, 2025
64 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants