-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[perf] Setup iOS performance measurements on CoreCLR #120139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[perf] Setup iOS performance measurements on CoreCLR #120139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR establishes performance measurement capabilities for iOS on CoreCLR by adding CoreCLR as a runtime option alongside the existing Mono support. The implementation includes parameter additions, runtime configuration options, and build pipeline integration.
- Adds CoreCLR runtime support to iOS performance measurements
- Configures iOS sample app to support both Mono and CoreCLR runtimes
- Integrates CoreCLR iOS scenarios into the performance build pipeline
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/mono/sample/iOS/Makefile | Adds runtime selection parameters (USE_MONO_RUNTIME, AOT) for CoreCLR support |
eng/pipelines/performance/templates/perf-ios-scenarios-build-jobs.yml | Introduces CoreCLR build job configuration for iOS performance scenarios |
eng/pipelines/performance/templates/build-perf-sample-apps.yml | Implements CoreCLR-specific iOS sample app build steps with interpreter mode |
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some questions but looks good in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment, but this looks good.
/ba-g #120317 |
Description
This PR sets up performance measurements for iOS on CoreCLR. It adds a runtime build job and a sample app build step.
Successful build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2806045&view=results