Skip to content

Conversation

sitole
Copy link
Member

@sitole sitole commented Sep 24, 2025

When 6662158 is deployed, we no longer need an infrastructure provisioning load balancer for the logs collector.


Note

Removes the external logs collector load balancer and wiring, dropping related vars/outputs/firewalls and adding logs port defaults in the Nomad module.

  • Infra removal (logs collector):
    • Delete google_compute_global_address.orch_logs_ip, module.gce_lb_http_logs, logs collector firewall rule, and google_compute_security_policy.disable-bots-log-collector in nomad-cluster/network.
    • Remove DNS/output for logs IP (network/outputs.tf) and nomad-cluster/outputs.tf exposure.
    • Drop logs_proxy_port/logs_health_proxy_port variables from nomad-cluster/network/variables.tf and nomad-cluster/variables.tf.
    • Remove named_port entries for logs from nomad-cluster/nodepool-client.tf.
  • Wiring changes:
    • Stop passing logs_proxy_port and logs_health_proxy_port through provider-gcp/main.tf into nomad-cluster and nomad.
  • Defaults:
    • Add defaults for logs_proxy_port and logs_health_proxy_port in iac/provider-gcp/nomad/variables.tf.
  • Minor:
    • Preserve nomad_port in nomad-cluster/main.tf (re-added line).

Written by Cursor Bugbot for commit 92954f0. This will update automatically on new commits. Configure here.

@sitole sitole added the improvement Improvement for current functionality label Sep 24, 2025
Copy link

linear bot commented Sep 24, 2025

@sitole sitole marked this pull request as ready for review September 24, 2025 10:28
@sitole sitole marked this pull request as draft September 24, 2025 10:29
@sitole
Copy link
Member Author

sitole commented Sep 24, 2025

Draft until rollout is finished.

@jakubno jakubno self-assigned this Sep 25, 2025
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests are still coming to the load balancer even after the rollout.

@sitole sitole force-pushed the remove-vector-public-load-balancer-from-iac-eng-3029 branch from b13e840 to 92954f0 Compare October 6, 2025 09:49
@sitole
Copy link
Member Author

sitole commented Oct 6, 2025

Requests are still coming to the load balancer even after the rollout.

Resolved in person. I think we can now move forward once we understand why this is happening.
Lmk if i should mark it as read @jakubno

@sitole sitole requested a review from jakubno October 6, 2025 15:57
@ValentaTomas ValentaTomas removed their request for review October 7, 2025 05:07
@sitole sitole marked this pull request as ready for review October 8, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants