-
Notifications
You must be signed in to change notification settings - Fork 38
Adds default config for run_evaluation #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TO DISCUSS: what is best run_id to have as default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
About your point on the Run_Id: I'd just copy paste the config that we have now in the WG and keep the run_id we have there. it is just to have an example then people will change it as they like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this over, Sorcha. I have added a couple of comments to improve applicability accross HPCs and prevent additional workload when the evaluation pipeline changes.
I verified the code with the changes I have made. It runs without passing --config config/eval_config.yml
. Kindly have a look; curious to hear your opinion.
Another thought: How about adding the parser.add_argument(
"--config",
type=str,
default=Path("config/eval_config.yml"),
help="Path to the configuration yaml file for plotting. e.g. config/eval_config.yaml",
) Then we would not have to do the if/else check further below. |
My only concern with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Code tested successfully, default ./config/evaluate/eval_config.yml
is selected when no argument is provided. Passing a particular config file still works with --config path/to/eval_config.yml
* adding default config + changing yml path locations * linter checks * linter checks * revert .yml file * updates --------- Co-authored-by: iluise <[email protected]>
Description
uv run --offline evaluate
is all requiredplot_config_template.yml
grwnhykd
results_base_dir
to"/p/scratch/weatherai/shared_work/results/"
instead of"./results"
Issue Number
Closes #693
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint
./scripts/actions.sh unit-test
./scripts/actions.sh integration-test
: FAILSlaunch-slurm.py --time 60