Use sqlglot to properly check SQL delta files #19224
Merged
+131
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/sqlglot
branch
4 times, most recently
from
025de4f to
603ebed
Compare
erikjohnston
force-pushed
the
erikj/sqlglot
branch
from
603ebed to
a48a2fb
Compare
anoadragon453
approved these changes
Nov 28, 2025
Co-authored-by: Andrew Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using dodgy regexes which keep breaking.
Also fixes a regression where it looks like we didn't fail CI if the delta was in the wrong place.