Avoid throwing of plain JS strings. NFC

[sbc100]

Replaced with assert, abort or throw new Error accordingly. We almost never want to be throwing plain values because we don't end up with a stack trace in that case.

[brendandahl]

What's the criteria for choosing throw new Error vs abort?

[sbc100]

What's the criteria for choosing throw new Error vs abort?

I tried to use abort whenever I know that the code is running in the context of emscripten-generated code, and after the definition of abort itself (which I think happens in shell.js).

[sbc100]

What's the criteria for choosing throw new Error vs abort?

I tried to use abort whenever I know that the code is running in the context of emscripten-generated code, and after the definition of abort itself (which I think happens in shell.js).

But I now that I wasn't very consistent :)

[sbc100]

Ok, should be more consistent now. I've used abort whereever I'm sure its ok to us it.