Skip to content

listener: log on start of connections #41747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

listener: log on start of connections #41747

wants to merge 7 commits into from

Conversation

@kyessenov
Copy link
Contributor

@kyessenov kyessenov commented Oct 28, 2025 •
edited
Loading

Change-Id: Ib636893790ae88641e170119442098378b88a614

Commit Message: Extend listener access log to log on raw connection start.
Additional Description:
Risk Level: low, new API. However, I updated access log type for the existing log entry, to make it different.
Testing: added
Docs Changes: yes
Release Notes: yes

@kyessenov
listener: log on connected
cc40fc7 
Change-Id: Ib636893790ae88641e170119442098378b88a614
Signed-off-by: Kuat Yessenov <[email protected]>
@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Oct 28, 2025

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41747 was opened by kyessenov.

see: more, trace.

@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Oct 28, 2025

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #41747 was opened by kyessenov.

see: more, trace.

@kyessenov
format
cb324ba 
Change-Id: If891a208cdc5a5f547a53f602944b3235754437a
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov kyessenov mentioned this pull request Oct 30, 2025
Merged
@kyessenov
add docs
7cdf076 
Change-Id: I6f2c728a63452bde9008a1bf14758fe7ead1a45d
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
implementation
89cfaa7 
Change-Id: I3da99edf0e9b21567dca716875d6a648304cad01
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov kyessenov changed the title listener: log on connected listener: log on start of connections Oct 31, 2025
@kyessenov kyessenov marked this pull request as ready for review October 31, 2025 23:49
wbpcode
wbpcode reviewed Nov 1, 2025
View reviewed changes
@kyessenov
fix
4d21963 
Change-Id: If964027bcedb748f955b6f375653b093e3a8f951
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
fix tests
47fe81d 
Change-Id: I478bb9a4baba738ebf224cf90ba5bd13a71bad6f
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
fix
5071f7c 
Change-Id: Ic14bf3d8749362df241e2d9c9de6f1b058197753
Signed-off-by: Kuat Yessenov <[email protected]>
@agrawroh
Copy link
Member

agrawroh commented Nov 3, 2025

/assign @wbpcode

@kyessenov
Copy link
Contributor Author

kyessenov commented Nov 4, 2025

/wait
I think I need to have "on TLS handshake" as well, will add that to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbpcode wbpcode wbpcode left review comments

@ggreenway ggreenway Awaiting requested review from ggreenway ggreenway is a code owner

@adisuissa adisuissa Awaiting requested review from adisuissa adisuissa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@abeyad abeyad

@wbpcode wbpcode

Labels

api waiting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kyessenov @agrawroh @wbpcode @abeyad