Skip to content

Conversation

DipakHalkude
Copy link

…fter eject

Copy link

meta-cla bot commented Sep 23, 2025

Hi @DipakHalkude!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@DipakHalkude
Copy link
Author

Problem:
After eject, apps on React 17+ can hit “ReferenceError: React is not defined” when using the automatic JSX transform because the ejected Babel config didn’t explicitly set the JSX runtime, effectively falling back to classic.
Change: Update packages/react-scripts/scripts/eject.js to detect react/jsx-runtime and write Babel presets in package.json as:
["react-app", { "runtime": "automatic" | "classic" }]
Mirrors the runtime detection already used in webpack and jest configs.

Impact:
Ejected apps with React 17+ continue to work without import React. No change for React < 17 or when DISABLE_NEW_JSX_TRANSFORM=true.

Files
packages/react-scripts/scripts/eject.js

@DipakHalkude
Copy link
Author

I signed the CLA

@meta-cla meta-cla bot added the CLA Signed label Sep 23, 2025
Copy link

meta-cla bot commented Sep 23, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant