Skip to content

fix(eject): preserve React 17 automatic JSX runtime after eject (#9953, #17109) #17147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

fix(eject): preserve React 17 automatic JSX runtime after eject (#9953, #17109) #17147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion packages/react-scripts/scripts/eject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,29 @@ prompts({

// Add Babel config
console.log(` Adding ${cyan('Babel')} preset`);
// Detect if the new JSX transform is available and prefer it after eject
const hasJsxRuntime = (() => {
if (process.env.DISABLE_NEW_JSX_TRANSFORM === 'true') {
return false;
}
try {
require.resolve('react/jsx-runtime');
return true;
} catch (e) {
return false;
}
})();

appPackage.babel = {
presets: ['react-app'],
// Preserve preset with explicit runtime so ejected apps keep working without importing React
presets: [
[
'react-app',
{
runtime: hasJsxRuntime ? 'automatic' : 'classic',
},
],
],
};

// Add ESlint config
Expand Down