Fix: Fixed issue where archives opened in new tab instead of existing one #17394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where ZIP archives would open in a new tab instead of the existing tab when multiple applications were registered for the .zip file extension. The issue occurred because only the first file association was checked, which might not be the Files app itself.
- Refactored file association checking to examine all registered associations instead of just the first one
- Added new method
GetAllFileAssociationsAsyncto retrieve all file associations for a given file type - Updated the ZIP folder logic to use
Any()check across all associations to determine if Files app can handle the file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ZipStorageFolder.cs | Updated CheckDefaultZipApp to use new method that checks all file associations instead of just the first one |
| Win32Helper.Storage.cs | Added GetAllFileAssociationsAsync method and refactored existing association logic into reusable helper methods |
yaira2
changed the title
yaira2
changed the title
yaira2
force-pushed
the
16646-open-archive-in-existing-tab
branch
from
2109996 to
11b054b
Compare
|
If I change the default association to File Explorer, it still opens in Files. The expected behavior is to respect the default association. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
Description
On my system, multiple applications were returned for the .zip file extension. The first association returned was not Files, which caused .zip files to open in a new tab instead of the same one.
With this change, all associations are now checked