Skip to content

Conversation

wellnana
Copy link
Contributor

The Dependency::FromStr implementation sets url to None when the input is treated as an alias-only dependency, eg forge-std, so we can try to get the url from the git config.

Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing

@onbjerg onbjerg self-assigned this Sep 16, 2025
@grandizzy grandizzy moved this to In Progress in Foundry Sep 22, 2025
@wellnana
Copy link
Contributor Author

The test is failing

Ah, I shouldn't change cmd.rs revert now, not sure why its flaky test here, but should be good this time

@onbjerg onbjerg merged commit f3625e0 into foundry-rs:master Sep 24, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Foundry Sep 24, 2025
@grandizzy grandizzy moved this from Done to Completed in Foundry Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

2 participants