fix(settings): Defensively check existence of project in case of project deletion #102969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
shashjar
commented
Nov 7, 2025
| [navigate, organization.slug, routes, location] | ||
| ); | ||
|
|
||
| if (!project?.id) { |
Member
Author
There was a problem hiding this comment.
I considered instead modifying ProjectContext to update the project state only if the project ID still exists in the ProjectsStore (and therefore hasn't been deleted), but I don't want to set the pattern that those two can be kept out of date with each other. So I decided to just add a defensive check here since this bug is scoped only to project deletion.
scttcper
approved these changes
Nov 7, 2025
shashjar
deleted the
defensive-project-check-in-project-general-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defensively checking the existence of
projectto protect against project deletion and a subsequent re-render.