Skip to content

fix(settings): Defensively check existence of project in case of project deletion #102969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

fix(settings): Defensively check existence of project in case of project deletion #102969

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b810d55
Defensively check existence of project (in case of project deletion a…
shashjar Nov 7, 2025
8d799d1
Return `LoadingError` when project not found
shashjar Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion static/app/views/settings/projectGeneralSettings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export function ProjectGeneralSettings({project, onChangeSlug}: Props) {
disabled: !hasEveryAccess(['project:write'], {organization, project}),
};

const team = project.teams.length ? project.teams?.[0] : undefined;
const team = project.teams?.[0];

// XXX: HACK
//
Expand Down Expand Up @@ -442,5 +442,9 @@ export default function ProjectGeneralSettingsContainer() {
[navigate, organization.slug, routes, location]
);

if (!project?.id) {
Copy link
Member Author

@shashjar shashjar Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered instead modifying ProjectContext to update the project state only if the project ID still exists in the ProjectsStore (and therefore hasn't been deleted), but I don't want to set the pattern that those two can be kept out of date with each other. So I decided to just add a defensive check here since this bug is scoped only to project deletion.

return null;
}

return <ProjectGeneralSettings project={project} onChangeSlug={handleChangeSlug} />;
}
Loading