ref(replay): move summary log parsing to a seer rpc #99547
Conversation
github-actions
bot
added
the
Scope: Backend
| SEER_START_TASK_ENDPOINT_PATH, | ||
| { | ||
| "logs": [], | ||
| "use_rpc": True, |
There was a problem hiding this comment.
Used to toggle code paths in seer (default false)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #99547 +/- ##
=======================================
Coverage 81.20% 81.20%
=======================================
Files 8563 8563
Lines 380233 380265 +32
Branches 23953 23953
=======================================
+ Hits 308773 308804 +31
- Misses 71109 71110 +1
Partials 351 351 |
| if features.has( | ||
| "organizations:replay-ai-summaries-rpc", project.organization, actor=request.user | ||
| ): | ||
| start, end = default_start_end_dates() |
There was a problem hiding this comment.
deciding to not support date params, imo it's not necessary. We don't pass these in from the frontend atm
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| "organizations:replay-ai-summaries-rpc", project.organization, actor=request.user | ||
| ): | ||
| start, end = default_start_end_dates() | ||
| snuba_response = query_replay_instance( |
There was a problem hiding this comment.
isn't the query_replace_instance call in the other (summarize.py) file already?
There was a problem hiding this comment.
i guess i'm confused why we have this call + also the other one
There was a problem hiding this comment.
I wanted to 404 early if the replay's missing, instead of making a seer task + db entry
There was a problem hiding this comment.
Colton is working on a more efficient existence check but hope this will do til then. Can test with the FF
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
Currently segment downloads and log parsing are done synchronously, before queueing a summary task in Seer. This PR moves that work to a RPC call which will be called by the task, allowing project_replay_summary endpoint to be fully async/return immediately.
Changes in both services can be rolled out together with a new FF.
Part of REPLAY-708: Move POST endpoint log parsing to Seer->Sentry RPC