docs(sourcebundle): Fix incomplete sentence #940
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentence, as written, is incomplete. I asked Cursor to infer what the rest of the sentence should be; this is what it proposed, giving the following justification: > Looking at the implementation, I can see that: > > 1. The `SourceBundleWriter` has a `finish` method (line 1414) that: > - Takes `self` by value (consumes the writer) > - Writes the manifest > - Finalizes the underlying `ZipWriter` > > 2. There's **no `Drop` implementation** for `SourceBundleWriter` > > 3. The example code explicitly shows calling `bundle.finish()?;` to properly flush the bundle
loewenheim
approved these changes
Nov 5, 2025
|
@jan-auer, the original author, confirmed in Slack that this is likely what he meant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentence, as written, is incomplete. I asked Cursor to infer what the rest of the sentence should be; this is what it proposed, giving the following justification: