bug: getSkipPoint never returns number type value #1080
Conversation
|
It looks like npm install timed out because of network issue, is there anyway to re-trigger it? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the getSkipPoint function where it was missing a return statement, causing it to always return undefined instead of the intended number value. The fix adds the missing return statement to return the calculated drawRegionsLowestY value.
Key Changes
- Adds missing return statement to
getSkipPointfunction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -7,6 +7,7 @@ export function getSkipPoint(drawRegions: readonly Rectangle[]): number | undefi | |||
| for (const dr of drawRegions) { | |||
| drawRegionsLowestY = Math.min(drawRegionsLowestY ?? dr.y, dr.y); | |||
| } | |||
| return drawRegionsLowestY; | |||
There was a problem hiding this comment.
The function returns drawRegionsLowestY which is initialized as undefined and will remain undefined if the drawRegions array is empty. Consider returning a default value or handling the empty array case explicitly to match the function's return type contract.
Copilot uses AI. Check for mistakes.
It seems
getSkipPointsuppose to return eithernumberorundefinedbut it's actually never returnsnumber