Skip to content

bug: getSkipPoint never returns number type value #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

bug: getSkipPoint never returns number type value #1080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b73f8e
bug: getSkipPoint never returns number type value
ImmortalRabbit Aug 9, 2025
d8ce80d
Merge branch 'main' into return-value-for-get-skip-point
lukasmasuch Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/internal/data-grid/render/data-grid-render.walk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export function getSkipPoint(drawRegions: readonly Rectangle[]): number | undefi
for (const dr of drawRegions) {
drawRegionsLowestY = Math.min(drawRegionsLowestY ?? dr.y, dr.y);
}
return drawRegionsLowestY;
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function returns drawRegionsLowestY which is initialized as undefined and will remain undefined if the drawRegions array is empty. Consider returning a default value or handling the empty array case explicitly to match the function's return type contract.

Copilot uses AI. Check for mistakes.

}

export type WalkRowsCallback = (
Expand Down