-
Notifications
You must be signed in to change notification settings - Fork 73
Dependencies for the GDExtension Rider platform #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ndard libraries are automatically resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these configurations intended for building godot-cpp for working on godot-cpp itself? Or, are these intended for developers creating an extension that uses godot-cpp?
Can you provide some information on how these are meant to be used by developers and how we can maintain them over time?
Since I don't personally understand how these files work, I'm wary of merging this without more information
targets/godot.props
Outdated
<NMakeReBuildCommandLine>echo Starting SCons & scons --directory="$(ProjectDir.TrimEnd('\'))" dev_build=yes</NMakeReBuildCommandLine> | ||
<NMakeCleanCommandLine>echo Starting SCons & scons --clean --directory="$(ProjectDir.TrimEnd('\'))" dev_build=yes</NMakeCleanCommandLine> | ||
<NMakeOutput Condition="'$(NMakeOutput)' == ''">bin/godot.macos.editor.dev</NMakeOutput> | ||
<NMakePreprocessorDefinitions>TOOLS_ENABLED;DEBUG_ENABLED;DEV_ENABLED;ENGINE_UPDATE_CHECK_ENABLED;NO_EDITOR_SPLASH;ACCESSKIT_DYNAMIC;ACCESSKIT_ENABLED;MACOS_ENABLED;UNIX_ENABLED;COREAUDIO_ENABLED;COREMIDI_ENABLED;GLES3_ENABLED;METAL_ENABLED;RD_ENABLED;VULKAN_ENABLED;MINIZIP_ENABLED;BROTLI_ENABLED;THREADS_ENABLED;CLIPPER2_ENABLED;ZLIB_DEBUG;ZSTD_STATIC_LINKING_ONLY;VK_USE_PLATFORM_MACOS_MVK;VK_USE_PLATFORM_METAL_EXT;GLAD_ENABLED;EGL_ENABLED;$(NMakePreprocessorDefinitions)</NMakePreprocessorDefinitions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these defines appear to be from Godot rather than godot-cpp? Like ACCESSKIT_ENABLED
, COREMIDI_ENABLED
, etc
However, I'm not sure what this file are used for
I see, what you mean. Thank you. |
I wonder if this might be better as a community-maintained template for users of Rider? I don't know if anyone on the GDExtension team uses Rider, and would be able to test PRs for it or maintain it going foward. Whereas a small community of enthusiastic users of Rider could take that on |
It is up to you to decide if you'd like to incorporate the proposed changes. Kapture.2025-08-21.at.14.37.17.mp4A bit of me struggling with typing code. But the experience of GDExtension and the game in one place might be very good after all. (GodotEditor should be running all the time) |
Automatically resolves C++ standard libraries.
I have tested on Mac and Windows.