-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Multiple Windows Demo #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
misc/multiple_windows/scenes/draggable_window/draggable_region.gd
Outdated
Show resolved
Hide resolved
misc/multiple_windows/scenes/draggable_window/sprite_polygon_passthrough.gd
Outdated
Show resolved
Hide resolved
misc/multiple_windows/scenes/draggable_window/sprite_polygon_passthrough.gd
Outdated
Show resolved
Hide resolved
Thanks @AThousandShips , your fixes of GDScript style has been commited. |
misc/multiple_windows/scenes/confimation_dialogue/confirmation_dialog.tscn
Outdated
Show resolved
Hide resolved
misc/multiple_windows/scenes/accept_dialogue/accept_dialog.tscn
Outdated
Show resolved
Hide resolved
Noooooo there is more |
Looks great so far! I wonder if this demo should be used to showcase tray icons, or whether we should use the existing Operating System Testing demo for that instead. |
StatusIndicator is a separate class from OS, so I feel fine with adding it to this demo. Although that feature only working on Windows and MacOS does make it an OS specific thing. Will make a commit later with adding tray functionality to this demo. |
d4bf4eb
to
9caa8e1
Compare
9 Commits were squashed into 1 |
Fixed Draggable Window not receiving input when cursor doesn't overlap window. |
f196259
to
dde8496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! I think this demo is plenty sufficiently complex to justify it being separate from the OS testing demo.
Can you update this to Godot 4.5? It wouldn't be hard for others to do it but we will need to do it eventually.
misc/multiple_windows/scenes/draggable_window/sprite_polygon_passthrough.gd
Outdated
Show resolved
Hide resolved
While i was migrating to 4.5 fixed a bug with FIleDialog not opening up |
Co-Authored-By: A Thousand Ships <[email protected]> Co-Authored-By: Aaron Franke <[email protected]>
24b8634
to
1255cc1
Compare
Commits squashed! I'm pretty excited! 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to drag an embedded subwindow, the rate does not match my cursor speed on my 200% scaled high-DPI screen:
subwindow.mp4
misc/multiple_windows/scenes/draggable_window/sprite_polygon_passthrough.gd
Outdated
Show resolved
Hide resolved
I honestly am not sure how to fix this problem? It seems that |
I think that a better approach would be to use the new-ish This should take care of everything and is also a requirement for Wayland dragging as it does not support window warping. |
Done! Did not know that function got added in 4.4 |
A demo showing all Window classes and their use within the main window.
Preview:
