Make most container template copy constructors explicit #111372
+247
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
container-template-explicit-copy
branch
from
ba2cd46 to
5e36c4f
Compare
aaronfranke
force-pushed
the
container-template-explicit-copy
branch
from
5e36c4f to
ae2bf33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes most container copy constructors explicit. Specifically
CowData,FixedVector,HashMap,HashSet,List,LocalVector,RBMap, andRBSet. These already had many places in the code where copies were implicitly happening, but now the copies are explicit.This is most of the template containers, except for
Vector, since changing that type would be a really big change and should probably get its own PR. This PR also doesn't changeArrayandDictionary, which are also big changes.