chore: update read stats to use xcap #20095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
approved these changes
Dec 3, 2025
Member
rfratto
left a comment
rfratto
left a comment
There was a problem hiding this comment.
Great to see the line count go down :)
| // Close closes the Reader. Closed Readers can be reused by calling | ||
| // [Reader.Reset]. | ||
| func (r *Reader) Close() error { | ||
| r.region.End() |
Member
There was a problem hiding this comment.
This should check to see if region is nil, since if you create a Reader and immediately close it without reading first, region won't be defined and this will panic
| // Column statistics | ||
| PrimaryColumns uint64 // Number of primary columns to read from the dataset | ||
| SecondaryColumns uint64 // Number of secondary columns to read from the dataset | ||
| StatPrimaryColumns = xcap.NewStatisticInt64("primary.columns", xcap.AggregationTypeSum) |
Member
There was a problem hiding this comment.
nit: do these need to be exported?
| agg.Record(o) | ||
| } | ||
|
|
||
| func (r *Region) Observations() []AggregatedObservation { |
Member
There was a problem hiding this comment.
nit: please add doc comments for public methods 🙏
ashwanthgoli
force-pushed
the
xcap-read-stats
branch
from
be3da82 to
601dfcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates dataset reader to capture observations to xcap region which gets linked as child to the parent operation's region (DataObjscan, streamsview or Metastore)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR