Skip to content

Conversation

bitwiseman
Copy link
Member

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@bitwiseman bitwiseman force-pushed the pagination-cleanup2 branch from f2991da to 7fdfb85 Compare May 3, 2025 07:40
@bitwiseman bitwiseman force-pushed the pagination-cleanup2 branch from da424c8 to 01f8dfa Compare May 5, 2025 16:40
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 93.42105% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.01%. Comparing base (3745013) to head (87677f3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/kohsuke/github/PaginatedEndpointItems.java 75.86% 4 Missing and 3 partials ⚠️
...ain/java/org/kohsuke/github/PaginatedEndpoint.java 94.54% 2 Missing and 1 partial ⚠️
.../java/org/kohsuke/github/GHCommitFileIterable.java 71.42% 1 Missing and 1 partial ⚠️
...java/org/kohsuke/github/GHCommitSearchBuilder.java 87.50% 1 Missing ⚠️
...n/java/org/kohsuke/github/PagedSearchIterable.java 75.00% 1 Missing ⚠️
...ava/org/kohsuke/github/PaginatedEndpointPages.java 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2099      +/-   ##
============================================
- Coverage     85.02%   85.01%   -0.01%     
- Complexity     2495     2501       +6     
============================================
  Files           237      232       -5     
  Lines          7351     7283      -68     
  Branches        388      372      -16     
============================================
- Hits           6250     6192      -58     
+ Misses          871      868       -3     
+ Partials        230      223       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant