-
Notifications
You must be signed in to change notification settings - Fork 339
fix: Update Services Dashboard count() queries to correctly use MVs #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 45a1fc8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. Changes are solid:
The approach matches ClickHouse MV best practices by separating aggregations from calculations. |
E2E Test Results✅ All tests passed • 46 passed • 3 skipped • 254s
|
28c6fc4 to
32556e6
Compare
knudtty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve with 1 nit
| alias: 'total_requests', | ||
| }, | ||
| { | ||
| valueExpression: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is valueExpression needed here anymore? Could it just be left out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Closes HDX-3057
This PR updates the Request Error Rate query config so that it can correctly leverage materialized views.