Skip to content

fix: Update Services Dashboard count() queries to correctly use MVs #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Dec 15, 2025
Merged

fix: Update Services Dashboard count() queries to correctly use MVs #1473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32556e6
fix: Update Services Dashboard count() configs to use MVs
pulpdrew Dec 12, 2025
45a1fc8
Merge branch 'main' into drew/fix-request-error-rate-config
kodiakhq[bot] Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-insects-shop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

fix: Update Request Error Rate config to use MVs
19 changes: 17 additions & 2 deletions packages/app/src/ServicesDashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,21 @@ function HttpTab({
whereLanguage: appliedConfig.whereLanguage || 'sql',
displayType: DisplayType.Line,
select: [
// Separate the aggregations from the rate calculation so that AggregatingMergeTree MVs can be used
{
valueExpression: `countIf(${expressions.isError}) / count()`,
valueExpression: '',
aggFn: 'count',
alias: 'total_requests',
},
{
valueExpression: '',
Copy link
Contributor

@knudtty knudtty Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is valueExpression needed here anymore? Could it just be left out?

Copy link
Contributor Author

@pulpdrew pulpdrew Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unfortunately required to satisfy the current types. We could potentially introduce an additional union item here to support an undefined valueExpression for aggFn: 'count'

Screenshot 2025-12-15 at 9 28 42 AM

aggFn: 'count',
aggCondition: expressions.isError,
aggConditionLanguage: 'sql',
alias: 'error_requests',
},
{
valueExpression: `error_requests / total_requests`,
alias: 'error_rate',
},
],
Expand Down Expand Up @@ -502,6 +515,7 @@ function HttpTab({
{source && requestErrorRateConfig && (
<DBTimeChart
sourceId={source.id}
hiddenSeries={['total_requests', 'error_requests']}
config={requestErrorRateConfig}
showDisplaySwitcher={false}
disableQueryChunking
Expand Down Expand Up @@ -1278,7 +1292,8 @@ function ErrorsTab({
displayType: DisplayType.StackedBar,
select: [
{
valueExpression: `count()`,
valueExpression: '',
aggFn: 'count',
},
],
numberFormat: INTEGER_NUMBER_FORMAT,
Expand Down
Loading