Skip to content

view platform: cleanup view service #967 #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

view platform: cleanup view service #967 #968

wants to merge 3 commits into from

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Jul 1, 2025 •
edited
Loading

This PR does the following:

  • Brings context.Context as first parameter of the functions getting it in input
  • Introduces a way to set a timeout when running a view via RunView
  • It removes the finality handler cause it is not needed anymore
  • It streamlines the use of local interfaces
  • Removes unnecessary functions from view.Manager
  • Introduces LocalFactory to create an instance of a view directly from a struct so to avoid any unnecessary struct marshaling.

Used by: hyperledger-labs/fabric-token-sdk#1040

@adecaro adecaro self-assigned this Jul 1, 2025
@adecaro adecaro added the enhancement New feature or request label Jul 1, 2025
@adecaro adecaro added this to the Q3 milestone Jul 1, 2025
@adecaro adecaro linked an issue Jul 1, 2025 that may be closed by this pull request
view platform: cleanup view service #967
Open
@adecaro adecaro requested a review from alexandrosfilios July 1, 2025 09:12
@adecaro adecaro force-pushed the 967-view-platform-cleanup-view-service branch from 988c447 to d2d4f56 Compare July 7, 2025 07:06
@adecaro adecaro mentioned this pull request Jul 7, 2025
Open
@adecaro adecaro force-pushed the 967-view-platform-cleanup-view-service branch from a126d13 to 6e690f4 Compare July 17, 2025 12:40
adecaro added 3 commits July 27, 2025 06:36
@adecaro
add TestNewLocalView
6db629c 
introduce local view factories
refactoring

Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
rebase fix
39c60cb 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
cleanup
b9bece2 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro adecaro force-pushed the 967-view-platform-cleanup-view-service branch from 6e690f4 to b9bece2 Compare July 27, 2025 04:45
@adecaro
Copy link
Contributor Author

adecaro commented Sep 2, 2025

This PR will be closed and the Issue will be addressed in a new PR.

@adecaro adecaro closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrosfilios alexandrosfilios Awaiting requested review from alexandrosfilios

Assignees

@adecaro adecaro

Labels
enhancement New feature or request
Projects
None yet
Milestone
Q3
Development

Successfully merging this pull request may close these issues.

view platform: cleanup view service
1 participant
@adecaro