ttx service: timeout via context - part 2 #1040
Closed
+223
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2025
| jsonSession := session2.JSON(context) | ||
| msg, err := jsonSession.ReceiveRawWithTimeout(time.Minute * 4) | ||
| span := trace.SpanFromContext(context.Context()) | ||
| span.AddEvent("start_receive_transaction_view") |
There was a problem hiding this comment.
It's better to use the method logger.DebugfContext
| // New returns a JSON-based session wrapping the passed session. | ||
| func New(context context.Context, s Session) *JSession { | ||
| span := trace.SpanFromContext(context) | ||
| span.AddEvent(fmt.Sprintf("Open json session to [%s:%s]", string(s.Info().Caller), s.Info().CallerViewID)) |
| // New returns a JSON-based session wrapping the passed session. | ||
| func New(context context.Context, s Session) *JSession { | ||
| span := trace.SpanFromContext(context) | ||
| span.AddEvent(fmt.Sprintf("Open json session to [%s:%s]", string(s.Info().Caller), s.Info().CallerViewID)) |
There was a problem hiding this comment.
s.Info() is an expensive call (it contains a lock). I would suggest you use it only once or even better you use the Eval util:
logger.DebugfContext(context, "Open json session: %s", logging.Eval(s.Info))
alexandrosfilios
approved these changes
Jul 7, 2025
adecaro
force-pushed
the
f-915-part2
branch
2 times, most recently
from
08b5077 to
0528814
Compare
clean jsession package FSC b9bece2d0ce57e207809c748f19f431ef0457d62 remove the need to pass a timeout Signed-off-by: Angelo De Caro <[email protected]>
|
this will be reworked in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires hyperledger-labs/fabric-smart-client#968.