Skip to content

Conversation

@jrjohnson
Copy link
Member

With the release of Safari 26 we drop testing for Safari 17.x

@netlify
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 47b0f14
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/690c46b0269cbd000843bb7f
😎 Deploy Preview https://deploy-preview-8818--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jrjohnson jrjohnson marked this pull request as ready for review October 2, 2025 23:05
@stopfstedt stopfstedt removed the request for review from michaelchadwick October 3, 2025 16:17
@stopfstedt stopfstedt added the run ui tests Run the expensive UI tests label Oct 3, 2025
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests keeps failing in browser-stack on an "invalid device" error.

@jrjohnson jrjohnson removed the run ui tests Run the expensive UI tests label Nov 6, 2025
With the release of Safari 26 we drop testing for Safari 17.x
The school label for this select is buried within the SVG, safari
doesn't love that. Might be a bug in Safari, or possibly the check, but
the fix is easy and harmless so going this way.
@jrjohnson jrjohnson added the run ui tests Run the expensive UI tests label Nov 6, 2025
@jrjohnson
Copy link
Member Author

Fixed the browser matrix and a random safari failure, this is ready now.

@stopfstedt stopfstedt dismissed their stale review November 6, 2025 22:34

stale review

@stopfstedt stopfstedt self-requested a review November 6, 2025 22:34
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt self-requested a review November 6, 2025 22:39
@stopfstedt stopfstedt merged commit 5ed89d1 into ilios:master Nov 6, 2025
38 checks passed
@jrjohnson jrjohnson deleted the browser-update branch November 6, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run ui tests Run the expensive UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants