Skip to content

Conversation

@vicocz
Copy link
Contributor

@vicocz vicocz commented Feb 15, 2025

Add handling of new manufacturer id and device name, both changed by firmware upgrade. But scanning now checks manufacturer prefix that contains firmware major version.
Additionally changed the check for BuWizz3 as well as it might be wrongly detected if renamed to BuWizz.

For details, see doc:

Resolves #142
Resolves #147

@vicocz vicocz marked this pull request as ready for review February 15, 2025 18:44
@johan1975blom
Copy link

How can I fix the detection of Buwizz2 having firmware 1.2.30. Or is there no solution yet?
Greetings,
Johan Blom

@vicocz
Copy link
Contributor Author

vicocz commented Mar 13, 2025

How can I fix the detection of Buwizz2 having firmware 1.2.30. Or is there no solution yet? Greetings, Johan Blom

Not sure if I understand you correctly. This pull request is the change which needs to be merged (and the app released) in order to have BW2 devices detected in case they have the latest firmware.

@imurvai Please merge this fix.

@johan1975blom
Copy link

So if I understand correctly, you will solve the detectionproblem and then update it in the BrickControllor2 app? And if so, when will it be available?

@vicocz
Copy link
Contributor Author

vicocz commented Mar 13, 2025

So if I understand correctly, you will solve the detectionproblem and then update it in the BrickControllor2 app? And if so, when will it be available?

I've solved that, this pull request contains all the required changes to support it.
But I'm only contributor here, I can bring fixes, but the repository owner has to merge it and create a release.

@johan1975blom
Copy link

Oops... I'm sorry I didn't realise you are a contributor. But thanks for the anwsers and your work anyway. Hopefully the owner will merge it soon.

@vicocz
Copy link
Contributor Author

vicocz commented Mar 15, 2025

Honestly, it seems to me this repository is kind of dormant. I can only hope all the fixes will be addressed soon.
I had to maintain my own fork with several fixes I needed for my usage of LEGO models.

@franck403
Copy link

the repository is very dormant I think

@imurvai
Copy link
Owner

imurvai commented Jun 8, 2025

hey @vicocz , sorry for not answering for a long time. Can you please summarize the status of the buwizz devices:

  • is BW2 fully working with this fix?
  • what's the status of BW3?
    I try to merge and release your PRs

@vicocz
Copy link
Contributor Author

vicocz commented Jun 8, 2025

hey @vicocz , sorry for not answering for a long time. Can you please summarize the status of the buwizz devices:

  • is BW2 fully working with this fix?
  • what's the status of BW3?
    I try to merge and release your PRs

Yes both BW3 and BW2 (old and new firmware as well) should be working, in the end I've changed the way how to detect BW3 and BW2 by manufacturer data as there was possible issue if someone renamed BuWizz3 device to 'BuWizz'.

J0EK3R pushed a commit to J0EK3R/brickcontroller2 that referenced this pull request Jul 3, 2025
* FIx DI setup for WIN app
* JK: CADA / MouldKing is working
---------
Co-authored-by: J0EK3R <J0EK3R3.3@WIN11>
Co-authored-by: Vit Nemecky <[email protected]>
@franck403
Copy link

hey @imurvai when will you merge the fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] BuWizz3 device is discovered as BuWizz2 if it has BuWizz name BuWizz2 could not be found if it has firmware 1.2.30

4 participants