Skip to content

Fix detection of BuWizz2 having firmware 1.2.30 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix detection of BuWizz2 having firmware 1.2.30 #143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c20c5f
Fix detection of BuWizz2 having firmware 1.2.30
Feb 15, 2025
4203caa
Fix build error due to my fork diffs
Feb 15, 2025
94ce7f3
fix detection - use manufacturer data instead of the local name
May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions BrickController2/BrickController2/DeviceManagement/BluetoothDeviceManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,19 @@ public async Task<bool> ScanAsync(Func<DeviceType, string, string, byte[]?, Task
case "98-01": return (DeviceType.SBrick, manufacturerData);
case "48-4d": return (DeviceType.BuWizz, manufacturerData);
case "4e-05":
if (advertismentData.TryGetValue(0x09, out byte[]? completeLocalName))
// detect using manufacterer data prefix
if (!manufacturerDataString.StartsWith("4e-05-42-57-03-"))
{
var completeLocalNameString = BitConverter.ToString(completeLocalName).ToLower();
if (completeLocalNameString == "42-75-57-69-7a-7a") // BuWizz
{
return (DeviceType.BuWizz2, manufacturerData);
}
else
{
return (DeviceType.BuWizz3, manufacturerData);
}
return (DeviceType.BuWizz2, manufacturerData);
}
else
{
return (DeviceType.BuWizz3, manufacturerData);
}
case "05-45": // BuWizz2 has new ID since firmware 1.2.30 - use BuWizz2 prefix
if (manufacturerDataString.StartsWith("05-45-42-57-02-"))
{
return (DeviceType.BuWizz2, manufacturerData);
}
break;
case "97-03":
Expand Down