Skip to content

Conversation

@wiedld
Copy link
Collaborator

@wiedld wiedld commented Sep 23, 2025

Which issue does this PR close?

Rationale for this change

Fixes regression for approx_percentile_cont.

What changes are included in this PR?

Adds a conditional, and a regression test.

FUTURE DATAFUSION UPGRADES

Should refer to the patch list of the previous PR:
#73

Then apply this single patch/commit.

crepererum and others added 13 commits September 5, 2025 12:54
)

Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20.
- [Release notes](https://github.com/tokio-rs/tracing/releases)
- [Commits](tokio-rs/tracing@tracing-subscriber-0.3.19...tracing-subscriber-0.3.20)

---
updated-dependencies:
- dependency-name: tracing-subscriber
  dependency-version: 0.3.20
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place.

test: recreating the iox plan:
* demonstrate the insertion of coalesce after the use of column estimates, and the removal of the test scenario's forcing of rr repartitioning

test: reproducer of SanityCheck failure after EnforceSorting removes the coalesce added in the EnforceDistribution

fix: special case to not remove the needed coalesce
…pache#17003)

* Support centroids config for `approx_percentile_cont_with_weight`

* Match two functions' signature

* Update docs

* Address comments and unify centroids config
…ntile_cont_with_weight` (apache#16999)

* Add sqllogictests

* Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight

* Update docs

* Add documentation and more tests
* feat: support distinct for window

* fix

* fix

* fisx

* fix unparse

* fix test

* fix test

* easy way

* add test

* add comments
…he#17404)

* test: regression test for apache#17372

* test: add more direct regression for apache#17372

* fix: return ALL constants in `EquivalenceProperties::constants`
…he#17431)

* feat: Support binary data types for `SortMergeJoin` `on` clause

* Add sql level tests for merge join on binary keys

---------

Co-authored-by: Andrew Lamb <[email protected]>
* test: reproducer of bug
* fix: make schema names unique for approx_percentile_cont
* test: regression test is now resolved
@alamb alamb changed the base branch from upgrade-df-ver4902-a to base-df-upgrade-ver4902 October 22, 2025 16:48
@alamb
Copy link
Collaborator

alamb commented Oct 22, 2025

I changed the base on this PR so the PR shows all patches applied to the release version of DataFusion 49.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants